Re: Minor breaking change of chop(Iterator, int...) method for Groovy 5

2025-04-07 Thread Paul King
I added the PR for the trailing list edge case here: https://github.com/apache/groovy/pull/2180 On Mon, Apr 7, 2025 at 7:12 AM Paul King wrote: > > Actually, there is another edge case with chop that I would also like > to modify since we are making a change anyway. > > Even once the original so

Re: Minor breaking change of chop(Iterator, int...) method for Groovy 5

2025-04-06 Thread Paul King
Actually, there is another edge case with chop that I would also like to modify since we are making a change anyway. Even once the original source of elements is exhausted, we continue "chopping" for each asked for size but give an empty list in such cases. assert ['a', 'b', 'c', 'd', 'e'].chop(1

Re: Minor breaking change of chop(Iterator, int...) method for Groovy 5

2025-04-05 Thread OCsite
Hi there, > On 4. 4. 2025, at 23:09, Mattias Reichel wrote: > I don't see a problem making a breaking change in a major version update. Well it's always somewhat at the inconvenient side for us who maintain a big codebase. On the other hand, when it's easy to find and fix all the places where

Re: Minor breaking change of chop(Iterator, int...) method for Groovy 5

2025-04-04 Thread Mattias Reichel
I don't see a problem making a breaking change in a major version update. Thanks for the thorough explanation! /Mattias Den fre 4 apr. 2025 kl 17:57 skrev Per Nyfelt : > I think the change is good and the right one. Consistency of API will > bring a much better benefit in the long run compared s

Re: Minor breaking change of chop(Iterator, int...) method for Groovy 5

2025-04-04 Thread Per Nyfelt
I think the change is good and the right one. Consistency of API will bring a much better benefit in the long run compared so the initial discomfort to adapt. Regards, Per On 4/4/25 13:41, Paul King wrote: Hi folks, I am seeking feedback on making a breaking change for the DGM chop method (