Re: Applying Parameters to Discovered Brokers

2010-07-23 Thread nondescript1
Filed https://issues.apache.org/activemq/browse/AMQ-2849 AMQ-2849 for this issue. -- View this message in context: http://old.nabble.com/Applying-Parameters-to-Discovered-Brokers-tp29239157p29249888.html Sent from the ActiveMQ - User mailing list archive at Nabble.com.

Re: Applying Parameters to Discovered Brokers

2010-07-23 Thread nondescript1
A call hierarchy on the DiscoveryTransport constructor reveals that it is instantiated in FanoutTransportFactory and DiscoveryTransportFactory, which extends FailoverTransportFactory. In DiscoveryTransportFactory, the parameters are applied to the DiscoveryTransport. Wouldn't it be better to hav

Re: Applying Parameters to Discovered Brokers

2010-07-23 Thread Gary Tully
I think that is the correct approach. Compare FanoutTransportFactory.createTransport to some of the other transport factories, FailoverTransportFactory for example, it follows that pattern. Possibly open a jira issue and attach your patch and a test case to protect it. On 22 July 2010 17:51, nonde