Re: Performance issue in OrderedPendingList

2015-11-28 Thread David Sitsky
Thanks! On Sun, Nov 29, 2015 at 5:29 AM, Christopher Shannon < christopher.l.shan...@gmail.com> wrote: > I have merged this into master so it will go into 5.13.0 on Monday. I will > let Jenkins run our builds today to catch any problems but I don't expect > any issues. > > On Sat, Nov 28, 2015 a

Re: Performance issue in OrderedPendingList

2015-11-28 Thread Christopher Shannon
I have merged this into master so it will go into 5.13.0 on Monday. I will let Jenkins run our builds today to catch any problems but I don't expect any issues. On Sat, Nov 28, 2015 at 2:25 AM, Claus Ibsen wrote: > Yeah I agree. > > I just wonder if that loop was using equals and not comparing

Re: Performance issue in OrderedPendingList

2015-11-27 Thread Claus Ibsen
Yeah I agree. I just wonder if that loop was using equals and not comparing just the message id, maybe there was a purpose of the old code. But a git blame can maybe tell us more. On Sat, Nov 28, 2015 at 5:34 AM, David Sitsky wrote: > Done: https://issues.apache.org/jira/browse/AMQ-6066 > > If y

Re: Performance issue in OrderedPendingList

2015-11-27 Thread David Sitsky
Done: https://issues.apache.org/jira/browse/AMQ-6066 If you can incorporate the patch in for 5.13.0 I'd be very grateful.. as it is a pain for us to not use an official release. Also I believe this is a really important performance regression that we'd want to stomp out quickly for ActiveMQ.. Ma

Re: Performance issue in OrderedPendingList

2015-11-27 Thread Christopher Shannon
Claus is right, open up a Jira and I or someone else can take a look at this. I don't know if there will be enough time to put this in before 5.13.0 because I plan on starting the release Monday for that and I'd want to make sure all the tests run and there would be no unintended issues by making

Re: Performance issue in OrderedPendingList

2015-11-27 Thread Claus Ibsen
Hi Well spotted. I think a good idea is to log a JIRA ticket about this so its not forgotten and so the AMQ team can look at it and get it into the next release. On Fri, Nov 27, 2015 at 2:39 AM, David Sitsky wrote: > FWIW I changed the contains method as follows: > > @Override > public boolean c

Re: Performance issue in OrderedPendingList

2015-11-26 Thread David Sitsky
FWIW I changed the contains method as follows: @Override public boolean contains(MessageReference message) { if (message != null) { return map.containsKey(message.getMessageId()); } return false; } I got a speedup for my test taking 29 minutes from 41 minutes. Can we get this

Performance issue in OrderedPendingList

2015-11-25 Thread David Sitsky
Hi, I have updated my application from ActiveMQ 5.3 to 5.11.1 and have noticed a performance degregation issue. Running a number of jstacks I can see the broker is often stuck here: "Queue:master-items" Id=122 RUNNABLE at org.apache.activemq.broker.region.cursors.OrderedPendingList.contains(Orde