R: Artemis security plugin doesn't allow to change clientId

2022-05-05 Thread Modanese, Riccardo
ew more tests in the next days. Regards Riccardo Da: Justin Bertram Data: mercoledì, 4 maggio 2022 21:10 A: users@activemq.apache.org Oggetto: Re: Artemis security plugin doesn't allow to change clientId I just pushed the update. Let me know if the change works for you now. Thanks! Justin

Re: Artemis security plugin doesn't allow to change clientId

2022-05-04 Thread Justin Bertram
>> at >> java.base/java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:628) >> [java.base:] >> at >> org.apache.activemq.artemis.utils.ActiveMQThreadFactory$1.run(ActiveMQThreadFactory.java:118) >> [artemis-

Re: Artemis security plugin doesn't allow to change clientId

2022-05-04 Thread Justin Bertram
g.apache.activemq.artemis.utils.ActiveMQThreadFactory$1.run(ActiveMQThreadFactory.java:118) > [artemis-commons-2.23.0-SNAPSHOT.jar:] > > 2022-05-03 12:34:19,356 INFO > [org.eclipse.kapua.broker.artemis.plugin.security.DummyServerPlugin] ### > cleanUpConnectionData connection: fca276c8

R: Artemis security plugin doesn't allow to change clientId

2022-05-03 Thread Modanese, Riccardo
] ### cleanUpConnectionData connection: fca276c8 - reason: DESTROY - Error: N/A or 2 if you run again the test. Da: Justin Bertram Data: martedì, 26 aprile 2022 15:42 A: users@activemq.apache.org Oggetto: Re: Artemis security plugin doesn't allow to change clientId I assumed that since you could only reproduce th

Re: Artemis security plugin doesn't allow to change clientId

2022-04-26 Thread Justin Bertram
kapua/jetty-base > > 2.0.0-ARTEMIS-SNAPSHOT 3f2edd64f434 28 minutes ago 610MB > > kapua/jetty-base > > 2022-04-20 3f2edd64f434 28 minutes ago 610MB > > kapua/jetty-base > > latest 3f2edd64f434 28 minutes ago 610MB > &

R: Artemis security plugin doesn't allow to change clientId

2022-04-26 Thread Modanese, Riccardo
: Justin Bertram Data: martedì, 26 aprile 2022 00:20 A: users@activemq.apache.org Oggetto: Re: Artemis security plugin doesn't allow to change clientId I've given up reproducing this NPE for now. At this point can you confirm that the PR [1] fits your needs? If so, I can merge it and

Re: Artemis security plugin doesn't allow to change clientId

2022-04-25 Thread Justin Bertram
pose.diff > > > > cd deployment/docker/unix/ > > > > ./docker-deploy.sh > > > > > > > > once the environment is running you can run the test class > (TestMqttClient > > requires only log4j and Paho as external dependencies) > > > > &

R: Artemis security plugin doesn't allow to change clientId

2022-04-20 Thread Modanese, Riccardo
Bertram Data: martedì, 19 aprile 2022 18:07 A: users@activemq.apache.org Oggetto: Re: Artemis security plugin doesn't allow to change clientId Even after running `mvn clean install -DskipITs -DskipTests -Pdocker` I still get the same error when I run RunDeviceBrokerI9nTest:

Re: Artemis security plugin doesn't allow to change clientId

2022-04-19 Thread Justin Bertram
t; Riccardo > > > > *Da: *Modanese, Riccardo > *Data: *martedì, 12 aprile 2022 09:12 > *A: *users@activemq.apache.org > *Oggetto: *R: Artemis security plugin doesn't allow to change clientId > > Sure, the ITs are using docker images. You can build all the images with > doc

R: Artemis security plugin doesn't allow to change clientId

2022-04-12 Thread Modanese, Riccardo
time. Riccardo Da: Modanese, Riccardo Data: martedì, 12 aprile 2022 09:12 A: users@activemq.apache.org Oggetto: R: Artemis security plugin doesn't allow to change clientId Sure, the ITs are using docker images. You can build all the images with docker profile: mvn clean install -Dsk

R: Artemis security plugin doesn't allow to change clientId

2022-04-12 Thread Modanese, Riccardo
aprile 2022 19:10 A: users@activemq.apache.org Oggetto: Re: Artemis security plugin doesn't allow to change clientId I'm struggling to reproduce the NPE. I pulled down Kapua, switched to your branch (i.e. upgrade-artemis-2_21), configured Docker, etc., but I get this error

Re: Artemis security plugin doesn't allow to change clientId

2022-04-11 Thread Justin Bertram
ons. > > If could be helpful we had customized the wildcards to use the MQTT one (I > didn’t find any documentation about syntax changes on 2.22 so I’m assuming > is still valid right?) > > true > / > # > + > > > I’m looking forward for your feedback &

R: Artemis security plugin doesn't allow to change clientId

2022-04-11 Thread Modanese, Riccardo
is still valid right?) true / # + I’m looking forward for your feedback Thanks! Riccardo Da: Modanese, Riccardo Data: lunedì, 11 aprile 2022 08:58 A: users@activemq.apache.org Oggetto: R: Artemis security plugin doesn't allow to change clientId May be our plugin can be the

R: Artemis security plugin doesn't allow to change clientId

2022-04-10 Thread Modanese, Riccardo
May be our plugin can be the cause? Anyway I’m still investigating. Riccardo Da: Justin Bertram Data: venerdì, 8 aprile 2022 21:58 A: users@activemq.apache.org Oggetto: Re: Artemis security plugin doesn't allow to change clientId That's weird. There's a test in the ActiveMQ Art

Re: Artemis security plugin doesn't allow to change clientId

2022-04-08 Thread Justin Bertram
> + cherry-pick your commit) > The test I run was: RunDeviceBrokerI9nTest (see DeviceBrokerI9n.feature) > > Looking forward for your feedback! > > Riccardo > > > > > > > Da: Modanese, Riccardo > Data: venerdì, 8 aprile 2022 08:42 > A: users@activemq.apach

R: Artemis security plugin doesn't allow to change clientId

2022-04-08 Thread Modanese, Riccardo
@activemq.apache.org Oggetto: R: Artemis security plugin doesn't allow to change clientId Sure, I’ll test asap thanks! (I’m currently doing my testing on 2.19, I don’t expect conflicts if I cherry-pick the commit) Da: Justin Bertram Data: venerdì, 8 aprile 2022 03:05 A: users@activemq.apache.org Oggett

Re: Artemis security plugin doesn't allow to change clientId

2022-04-08 Thread Justin Bertram
ure, I’ll test asap thanks! > (I’m currently doing my testing on 2.19, I don’t expect conflicts if I > cherry-pick the commit) > > Da: Justin Bertram > Data: venerdì, 8 aprile 2022 03:05 > A: users@activemq.apache.org > Oggetto: Re: Artemis security plugin doesn't allow to ch

R: Artemis security plugin doesn't allow to change clientId

2022-04-07 Thread Modanese, Riccardo
Sure, I’ll test asap thanks! (I’m currently doing my testing on 2.19, I don’t expect conflicts if I cherry-pick the commit) Da: Justin Bertram Data: venerdì, 8 aprile 2022 03:05 A: users@activemq.apache.org Oggetto: Re: Artemis security plugin doesn't allow to change clientId I just sent

Re: Artemis security plugin doesn't allow to change clientId

2022-04-07 Thread Justin Bertram
I just sent a PR [1] for this. Riccardo, could you try this out and see if it works for you? Justin [1] https://github.com/apache/activemq-artemis/pull/4021 On Thu, Apr 7, 2022 at 2:04 PM Justin Bertram wrote: > I went ahead and opened ARTEMIS-3770 [1] for this work. > > > Justin > > [1] http

Re: Artemis security plugin doesn't allow to change clientId

2022-04-07 Thread Justin Bertram
I went ahead and opened ARTEMIS-3770 [1] for this work. Justin [1] https://issues.apache.org/jira/browse/ARTEMIS-3770 On Thu, Apr 7, 2022 at 12:35 PM Justin Bertram wrote: > Technically speaking, an implementation of > o.a.a.a.s.c.s.ActiveMQSecurityManager5 like you have *is* allowed to chang

Re: Artemis security plugin doesn't allow to change clientId

2022-04-07 Thread Justin Bertram
Technically speaking, an implementation of o.a.a.a.s.c.s.ActiveMQSecurityManager5 like you have *is* allowed to change the client ID on the o.a.a.a.s.c.p.RemotingConnection it receives (just as you are doing in your implementation). The problem is that MQTT implementation doesn't use this client ID

Artemis security plugin doesn't allow to change clientId

2022-04-07 Thread Modanese, Riccardo
Hello, we are moving a security plugin from ActiveMQ 5.x broker to Artemis 2.x. To summarize the use case: we need to prefix the MQTT client id provided during the connect with the account name (something like account_name|client_id) to allow devices with the same clientId, but different