> +++ b/fs/hostfs/hostfs_kern.c
> @@ -848,9 +848,11 @@ int hostfs_setattr(struct dentry *dentry, struct iattr
> *attr)
> attr->ia_size != i_size_read(inode)) {
> int error;
>
> - error = vmtruncate(inode, attr->ia_size);
> - if (err)
> -
First thanks a lot for doing this work, it's been long needed.
Second please don't send out that many patches. We encourage people
to split things into small patches when the changes are logially
separated. Which these are not - it's a flag day change (which btw
is fine despite the rants soe peo
> +void attr_kill_to_mode(struct inode *inode, struct iattr *attr)
This function badly needs a kerneldoc description. Also I can't say
I like the name a lot, but without a clearly better idea I should
probably not complain :)
We should at least add a generic_ prefix to indicate it's a generic
he
On Fri, Aug 10, 2007 at 04:47:52PM -0400, Jeff Layton wrote:
> attr->ia_valid after the setattr operation returns. If either ATTR_KILL_*
> bit is set then BUG(). The helper function already clears those bits
> so anything using it should automatically be ok. We'd have to fix
> up NFS and a few othe
