Re: [uml-user] [TRIVIAL PATCH 16/26] x86: Convert print_symbol to %pSR

2012-12-12 Thread Borislav Petkov
On Wed, Dec 12, 2012 at 01:30:03PM -0800, Joe Perches wrote: > > I think I'd go ahead and ACK this unless Tony has some comments. I'm > > not happy about the two pr_emerg calls based on the conditional. > > It was done to avoid interleaving. Right. > > Or, Tony, what do you think, could we get aw

Re: [uml-user] [TRIVIAL PATCH 16/26] x86: Convert print_symbol to %pSR

2012-12-12 Thread Borislav Petkov
L_CS. > That probably won't hurt anything, but... Yeah, that won't be an issue. So let's take it as is, as Tony suggests. Acked-by: Borislav Petkov Thanks. -- Regards/Gruss, Boris. Sent from a fat crate under my desk. Formatting is fine. --

Re: [uml-user] [TRIVIAL PATCH 16/26] x86: Convert print_symbol to %pSR

2012-12-12 Thread Borislav Petkov
On Wed, Dec 12, 2012 at 10:19:05AM -0800, Joe Perches wrote: > Use the new vsprintf extension to avoid any possible > message interleaving. > > Signed-off-by: Joe Perches > --- > arch/x86/kernel/cpu/mcheck/mce.c | 13 +++-- > arch/x86/kernel/dumpstack.c |5 ++--- > arch/x86/ke

Re: [uml-user] [TRIVIAL PATCH 16/26] x86: Convert print_symbol to %pSR

2012-12-13 Thread Borislav Petkov
On Thu, Dec 13, 2012 at 10:42:28AM -0800, H. Peter Anvin wrote: > On 12/13/2012 10:37 AM, Borislav Petkov wrote: > >> > >> If appropriate, the code could be changed to > >> > >>(void *)(unsigned long)m->ip > > > > Can we explicitly

Re: [uml-user] [TRIVIAL PATCH 16/26] x86: Convert print_symbol to %pSR

2012-12-13 Thread Borislav Petkov
On Thu, Dec 13, 2012 at 10:23:10AM -0800, Joe Perches wrote: > m->ip is a u64 so, when compiling x86-32, there's a new warning > "cast to pointer from integer of different size". This isn't new > different behavior, just a new warning. The previous print_symbol > took a ulong and the u64 was sile