Re: [uml-user] [PATCH v2.6.36-rc7] ubd: fix incorrect sector handling during request restart

2010-10-15 Thread Jens Axboe
On 2010-10-15 11:19, Tejun Heo wrote: > Commit f81f2f7c (ubd: drop unnecessary rq->sector manipulation) > dropped request->sector manipulation in preparation for global request > handling cleanup; unfortunately, it incorrectly assumed that the > updated sector wasn't being used. > > ubd tries to i

Re: [uml-user] [PATCH 1/1] um: ubd: Fix data corruption

2010-10-15 Thread richard -rw- weinberger
On Thu, Oct 14, 2010 at 3:14 PM, Tejun Heo wrote: > Hello, > > Can you please try this one then?  It seems to work here but I can't > reproduce the original problem reliably so I'm not really sure. > > Thanks. > > diff --git a/arch/um/drivers/ubd_kern.c b/arch/um/drivers/ubd_kern.c > index 1bcd208

[uml-user] [PATCH v2.6.36-rc7] ubd: fix incorrect sector handling during request restart

2010-10-15 Thread Tejun Heo
Commit f81f2f7c (ubd: drop unnecessary rq->sector manipulation) dropped request->sector manipulation in preparation for global request handling cleanup; unfortunately, it incorrectly assumed that the updated sector wasn't being used. ubd tries to issue as many requests as possible to io_thread. W

Re: [uml-user] [PATCH 1/1] um: ubd: Fix data corruption

2010-10-15 Thread Tejun Heo
Hello, On 10/14/2010 04:20 PM, richard -rw- weinberger wrote: > It does not work for me. > But the error is a different one. :-) > Without your patch I've never got this kernel trace. > > [ 59.85] kworker/0:1: page allocation failure. order:0, mode:0x20 Hmm... you're seeing out of memory c

Re: [uml-user] [PATCH 1/1] um: ubd: Fix data corruption

2010-10-15 Thread Chris Frey
On Thu, Oct 14, 2010 at 03:14:28PM +0200, Tejun Heo wrote: > Hello, > > Can you please try this one then? It seems to work here but I can't > reproduce the original problem reliably so I'm not really sure. > > Thanks. > > diff --git a/arch/um/drivers/ubd_kern.c b/arch/um/drivers/ubd_kern.c > in

Re: [uml-user] [PATCH 1/1] um: ubd: Fix data corruption

2010-10-15 Thread Tejun Heo
Hello, Can you please try this one then? It seems to work here but I can't reproduce the original problem reliably so I'm not really sure. Thanks. diff --git a/arch/um/drivers/ubd_kern.c b/arch/um/drivers/ubd_kern.c index 1bcd208..9734994 100644 --- a/arch/um/drivers/ubd_kern.c +++ b/arch/um/dr