Re: [uml-user] Slackware 12 root file system script and unknown partition

2007-08-06 Thread Blaisorblade
On giovedì 2 agosto 2007, Peter Chant wrote: > Chaps, > > I'm creating a script to generate a Slackware 12.0 based root file system > and also a script to run the uml machine. I'm running into a spot of > bother - it seems to mount the filesystem but complains about 'unknown > partition type' Tha

[uml-user] [PATCH 00/25] move handling of setuid/gid bits from VFS into individual setattr functions (RESEND)

2007-08-06 Thread Jeff Layton
Apologies for the resend, but the original sending had the date in the email header and it caused some of these to bounce... ( Please consider trimming the Cc list if discussing some aspect of this that doesn't concern everyone.) When an unprivileged process attempts to modify a file that has the

[uml-user] [PATCH 01/25] VFS: move attr_kill logic from notify_change into helper function

2007-08-06 Thread Jeff Layton
Separate the handling of the local ia_valid bitmask from the one in attr->ia_valid. This allows us to hand off the actual handling of the ATTR_KILL_* flags to the .setattr i_op when one is defined. notify_change still needs to process those flags for the local ia_valid variable, since it uses that

[uml-user] [PATCH 11/25] hostfs: call attr_kill_to_mode from hostfs_setattr

2007-08-06 Thread Jeff Layton
Signed-off-by: Jeff Layton <[EMAIL PROTECTED]> --- fs/hostfs/hostfs_kern.c |2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git a/fs/hostfs/hostfs_kern.c b/fs/hostfs/hostfs_kern.c index c778620..ea75204 100644 --- a/fs/hostfs/hostfs_kern.c +++ b/fs/hostfs/hostfs_kern.c @@ -833,

Re: [uml-user] Slackware 12 root file system script and unknown partition

2007-08-06 Thread Peter Chant
On Monday 06 August 2007, Blaisorblade wrote: On Monday 06 August 2007, you wrote: > That's usually normal. You do not want to have a partition table on a UML > image, normally you format the whole disk. Thanks, though not but I was trying to eliminate any errors. > > > and cannot write to the

Re: [uml-user] Slackware 12 root file system script and unknown partition

2007-08-06 Thread Peter Chant
On Monday 06 August 2007, Peter Chant wrote: > As I'm not greatly experienced with uml, and this is my first go at rolling > my own file system (I've upgraded other people's systems before) I'm a bit > concerned that I have multiple issues occuring. > > Pete Further comment, something must be wor

Re: [uml-user] [fuse-devel] [PATCH 01/25] VFS: move attr_kill logic from notify_change into helper function

2007-08-06 Thread Miklos Szeredi
> Separate the handling of the local ia_valid bitmask from the one in > attr->ia_valid. This allows us to hand off the actual handling of the > ATTR_KILL_* flags to the .setattr i_op when one is defined. > > notify_change still needs to process those flags for the local ia_valid > variable, since

Re: [uml-user] [fuse-devel] [PATCH 01/25] VFS: move attr_kill logic from notify_change into helper function

2007-08-06 Thread Jeff Layton
On Mon, 06 Aug 2007 19:43:46 +0200 Miklos Szeredi <[EMAIL PROTECTED]> wrote: > > Separate the handling of the local ia_valid bitmask from the one in > > attr->ia_valid. This allows us to hand off the actual handling of the > > ATTR_KILL_* flags to the .setattr i_op when one is defined. > > > > no

Re: [uml-user] [fuse-devel] [PATCH 01/25] VFS: move attr_kill logic from notify_change into helper function

2007-08-06 Thread Trond Myklebust
On Mon, 2007-08-06 at 20:28 +0200, Miklos Szeredi wrote: > Your patch is changing the API in a very unsafe way, since there will > be no error or warning on an unconverted fs. And that could lead to > security holes. > > If we would rename the setattr method to setattr_new as well as > changing

Re: [uml-user] [fuse-devel] [PATCH 01/25] VFS: move attr_kill logic from notify_change into helper function

2007-08-06 Thread Miklos Szeredi
> > I agree with this change and fuse will make use of it as well. > > > > Maybe instead of unconditionally moving attr_kill_to_mode() inside > > ->setattr() it could be made conditional based on an inode flag > > similarly to S_NOCMTIME. Advantages: > > > > - no need to modify a lot of in-tree

Re: [uml-user] [fuse-devel] [PATCH 01/25] VFS: move attr_kill logic from notify_change into helper function

2007-08-06 Thread Miklos Szeredi
> > Your patch is changing the API in a very unsafe way, since there will > > be no error or warning on an unconverted fs. And that could lead to > > security holes. > > > > If we would rename the setattr method to setattr_new as well as > > changing it's behavior, that would be fine. But I gues

Re: [uml-user] [fuse-devel] [PATCH 01/25] VFS: move attr_kill logic from notify_change into helper function

2007-08-06 Thread Trond Myklebust
On Mon, 2007-08-06 at 21:37 +0200, Miklos Szeredi wrote: > > > Your patch is changing the API in a very unsafe way, since there will > > > be no error or warning on an unconverted fs. And that could lead to > > > security holes. > > > > > > If we would rename the setattr method to setattr_new as