Re: Refactoring of Interceptor.intercept(ActionInvocation)

2009-10-06 Thread Chris Pratt
What does that have to do with method parameters? The ActionInvocation and any local variables are thread safe. I think the problem we're having in helping you is none of us understand what you're trying to accomplish? For instance why would you be trying to refactor away parameters that are req

Re: Refactoring of Interceptor.intercept(ActionInvocation)

2009-10-06 Thread Alex Siman
Am I right that storing request/session related info as interceptor fields is NOT safe due to concurrency? Such as interceptors are singletons and shared across all concurrent requests. Musachy Barroso wrote: > > yes, although I am kind of confused about your first email. > > musachy > > On Tu

Re: Refactoring of Interceptor.intercept(ActionInvocation)

2009-10-06 Thread Musachy Barroso
yes, although I am kind of confused about your first email. musachy On Tue, Oct 6, 2009 at 7:50 PM, Alex Siman wrote: > > Is it safe to get ActionInvocation inside of [Interceptor.intercept()] in > this way?: > > ActionInvocation invocation = > ActionContext.getContext().getActionInvocation(); >

Re: Refactoring of Interceptor.intercept(ActionInvocation)

2009-10-06 Thread Alex Siman
Is it safe to get ActionInvocation inside of [Interceptor.intercept()] in this way?: ActionInvocation invocation = ActionContext.getContext().getActionInvocation(); Alex Siman wrote: > > Is there any way to refactor method [intercept(ActionInvocation)] to > remove ActionInvocation parameter. It

Refactoring of Interceptor.intercept(ActionInvocation)

2009-10-06 Thread Alex Siman
Is there any way to refactor method [intercept(ActionInvocation)] to remove ActionInvocation parameter. It is not usable to have this parameter, because it makes refactoring of method interceptor hard. Instead of this: public class SomeInterceptor extends AbstractInterceptor { @Override