Re: Base action class

2005-10-07 Thread Leon Rosenberg
On 10/7/05, Frank W. Zammetti <[EMAIL PROTECTED]> wrote: > I don't know about you, but I see *WAY TOO MUCH* overengineering in many > projects. People are so anal about coming up with the absolute perfect > architectural solution. I'm not saying we shouldn't strive for > perfection, of course we

Re: Base action class

2005-10-07 Thread Michael Jouravlev
Leon, I have a question about this one: "You don't need to care for exceptions you don't understand (layer-technically, someone who writes an action doesn't care whether its an SQLException or a FileNotFoundException)" If you say, that it should be easy to switch layers, then persistence layer sh

Re: Base action class

2005-10-07 Thread Frank W. Zammetti
On Fri, October 7, 2005 3:05 am, Leon Rosenberg said: > If by persistance layers you mean things like hibernate and/or ibatis, > I would 100% agree with you. Yep, that's what I meant :) > But if you mean that if you have a BL > POJO, say IMessagingService, which uses two DBs (at least logical) >

Re: Base action class

2005-10-07 Thread Leon Rosenberg
On 10/6/05, Frank W. Zammetti <[EMAIL PROTECTED]> wrote: > Leon Rosenberg wrote: > > Well you shouldn't have anything with Database in the name in your > > action, it should be encapsulated in a service POJO. > > I'm not so sure about this... I understand the motivation for saying it > and agree wi

Re: Base action class

2005-10-06 Thread Frank W. Zammetti
Leon Rosenberg wrote: Well you shouldn't have anything with Database in the name in your action, it should be encapsulated in a service POJO. I'm not so sure about this... I understand the motivation for saying it and agree with that motivation, but it's a bit to hard-and-fast for my tastes.

Re: Base action class

2005-10-06 Thread Leon Rosenberg
On 10/6/05, Koen Jans <[EMAIL PROTECTED]> wrote: > > >What BaseActions also can do is to instantiate and manage resources > >(yes servlet content listener can do this too, but i like to have it > >in one place), services and so on. They also provide methods to handle > >request parameters typed (ge

RE: Base action class

2005-10-06 Thread Chris Bredesen
> As for now, i have put the basic stuff there like finding a > forward for a database faillure and so on.. I handle failures like this using the declarative exception handling (). One less thing I have to code in my Actions. > (like in the mailreader example by the way). Also, i have put > a

Re: Base action class

2005-10-06 Thread Koen Jans
Leon Rosenberg wrote: >personally I do overwrite execute in my baseaction and define an >abstract doExecute which all extending classes has to implement and >which is called by the execute method of the BaseAction after all >checks are done. thanks, this looks pretty good and helpfull. >What Bas

Re: Base action class

2005-10-06 Thread Leon Rosenberg
personally I do overwrite execute in my baseaction and define an abstract doExecute which all extending classes has to implement and which is called by the execute method of the BaseAction after all checks are done. My BaseAction usually also define methods which can be overridden by the extending

Re: Base action class

2005-10-06 Thread rajasekhar . cherukuri
It was a good idea to put the user logging check in the BaseAction class. This will be used as a firewall before allowing to access any resource (Action class). The required code for User Information check can be put in the execute method and another method like delegateToExecute(..) can be ma