Re: [S2] Configure Message Store Interceptor via Annotations

2007-10-13 Thread Gunnar Hillert
Hi Adam, I have created a ticket in Jira: https://issues.apache.org/struts/browse/WW-2252 and attached a first version with my changes to the interceptor. I was thinking of also adding functionality similar to your requirements. I totally agree that it would be nice if Struts 2 handled the sto

Re: [S2] Configure Message Store Interceptor via Annotations

2007-10-12 Thread Adam Hardy
Hi Gunnar I wanted it to work without needing to tell it when to do its stuff. I based my changes on the requirement for displaying success messages after a redirect. The messages / errors only need to survive until the next request. So anything in the request I put into the session (in the

Re: [S2] Configure Message Store Interceptor via Annotations

2007-10-11 Thread Gunnar Hillert
Hi Adam, Thanks for your comments. Yes, I looked at the sources for the MessageStoreInterceptor and indeed it looks quite simple. I played around with it tonight and I made the inteceptor annotations-aware. I have added 2 method-level annotations: @StoreMessages and @RetrieveMessages This works

Re: [S2] Configure Message Store Interceptor via Annotations

2007-10-11 Thread Adam Hardy
Gunnar, the message store interceptor is quite lean. I have copied it and written my own version to give me the functionality I needed. Now with your comments, it seems like a prime target for further development by S2 to beef it up a bit to provide more options. Maybe we could put in a patc