Re: UrlValidator (why not use java.net.URL?)

2005-07-28 Thread Laurie Harper
I'd guess the reason is to make it easier to keep the client- and server-side validation in sync. java.net.URL is, obviously, not available to the client-side validation. The Commons Validator list is probably the right place to follow this up. L. Marc Logemann wrote: Hi, after looking int

Re: UrlValidator (why not use java.net.URL?)

2005-07-28 Thread Marc Logemann
Hi, after looking into the code of UrlValidator and moreover looking into a similar class in Tapestry which is no longer active as it seems, i wonder why commons-validator UrlValidator is using Regex so much. Wouldnt it be enough to just use java.net.URL and let this class do the verification

Re: UrlValidator

2005-07-28 Thread Marc Logemann
Hi, if i have the time in the next days i will work on that, but where should i send a possible fix? struts-dev or to the commons-validator guys? Lindholm, Greg wrote: I encountered this awhile back but didn't have time to investigate. As a workaround I use the localhost IP address "127.0.0

RE: UrlValidator

2005-07-28 Thread Lindholm, Greg
I encountered this awhile back but didn't have time to investigate. As a workaround I use the localhost IP address "127.0.0.1" but it would be nice to get this fixed. -Original Message- From: Marc Logemann [mailto:[EMAIL PROTECTED] Sent: Thursday, July 28, 2005 8:33 AM To: user@struts.a

Re: UrlValidator() takes options - but how?

2004-04-01 Thread Niall Pemberton
To: "Struts Users Mailing List" <[EMAIL PROTECTED]> Sent: Thursday, April 01, 2004 3:24 PM Subject: Re: UrlValidator() takes options - but how? > Thanks for that Niall, you certainly know your stuff. > > I am thinking, if I change the UrlValidator in the source code, I cou

Re: UrlValidator() takes options - but how?

2004-04-01 Thread Niall Pemberton
;Adam Hardy" <[EMAIL PROTECTED]> To: "Struts Users Mailing List" <[EMAIL PROTECTED]> Sent: Thursday, April 01, 2004 3:24 PM Subject: Re: UrlValidator() takes options - but how? > Thanks for that Niall, you certainly know your stuff. > > I am thinking, if I chang

Re: UrlValidator() takes options - but how?

2004-04-01 Thread Adam Hardy
Thanks for that Niall, you certainly know your stuff. I am thinking, if I change the UrlValidator in the source code, I could submit a patch to allow FieldChecks to set the values from validation.xml. Currently, FieldChecks access UrlValidator via the GenericValidator: if (!GenericValidator.i

Re: UrlValidator() takes options - but how?

2004-04-01 Thread Niall Pemberton
UrlValidator is not the class that is instantiated by ValidatorAction because it doesn't know anything about Struts resources - the Struts FieldChecks.validateUrl() method calls commons GenericValidator which instantiates the UrlValidator. Rather than using the struts FieldChecks.validateUrl(), c