Re: Make base Action class a dispatch action

2006-05-09 Thread Dakota Jack
I agree completely with Niall on this one. I cannot believe that the basic action class could conceivably be considered to carry this overhead. On 5/9/06, Niall Pemberton <[EMAIL PROTECTED]> wrote: On 5/4/06, Michael Jouravlev <[EMAIL PROTECTED]> wrote: > What we has been brought from the stone

Re: Make base Action class a dispatch action

2006-05-09 Thread Niall Pemberton
On 5/9/06, Michael Jouravlev <[EMAIL PROTECTED]> wrote: On 5/9/06, Niall Pemberton <[EMAIL PROTECTED]> wrote: > On 5/4/06, Michael Jouravlev <[EMAIL PROTECTED]> wrote: > > What we has been brought from the stone ages: > > > > * Base Action class does not dispatch events > > * DispatchAction and i

Re: Make base Action class a dispatch action

2006-05-09 Thread Michael Jouravlev
On 5/9/06, Niall Pemberton <[EMAIL PROTECTED]> wrote: On 5/4/06, Michael Jouravlev <[EMAIL PROTECTED]> wrote: > What we has been brought from the stone ages: > > * Base Action class does not dispatch events > * DispatchAction and its flavors do, but they do not allow a user to > derive an action

Re: Make base Action class a dispatch action

2006-05-09 Thread Dave Newton
Niall Pemberton wrote: > Personally I'm against this because IMO it just adds > confusion/complexity to the Action class that is unnecessary for users > who don't want to use the "dispatch" style. Not if you use my idea of making the 'execute' method the default dispatch. Of course, don't name on

Re: Make base Action class a dispatch action

2006-05-09 Thread Niall Pemberton
On 5/4/06, Michael Jouravlev <[EMAIL PROTECTED]> wrote: What we has been brought from the stone ages: * Base Action class does not dispatch events * DispatchAction and its flavors do, but they do not allow a user to derive an action class from some another user's base action What we got now in

Re: Make base Action class a dispatch action

2006-05-04 Thread Dave Newton
Michael Jouravlev wrote: > * Stick dispatching features in base Action, thus making all actions > to be dispatch actions. > > Minor drawback: > > * only one dispatching behavior can be chosen. > > Thoughts? Objections? Suggestions? Works for me, with the following commentary (some of which may be

Re: Make base Action class a dispatch action

2006-05-04 Thread Don Brown
I like it, although you should probably bring this over to the dev list. :) Don On 5/4/06, Michael Jouravlev <[EMAIL PROTECTED]> wrote: What we has been brought from the stone ages: * Base Action class does not dispatch events * DispatchAction and its flavors do, but they do not allow a user t

Make base Action class a dispatch action

2006-05-04 Thread Michael Jouravlev
What we has been brought from the stone ages: * Base Action class does not dispatch events * DispatchAction and its flavors do, but they do not allow a user to derive an action class from some another user's base action What we got now in 1.2.9 and 1.3.1+ : * ActionDispatcher resolves the inher