RE: Is HttpParameters Supposed to be Immutable

2018-08-22 Thread Paul Zepernick
Thanks for the feedback. I will open up a bug and submit a PR 😊 Paul -Original Message- From: Lukasz Lenart Sent: Wednesday, August 22, 2018 12:54 AM To: Struts Users Mailing List Subject: Re: Is HttpParameters Supposed to be Immutable wt., 21 sie 2018 o 18:32 Paul Zepernick

Re: Is HttpParameters Supposed to be Immutable

2018-08-21 Thread Lukasz Lenart
wt., 21 sie 2018 o 18:32 Paul Zepernick napisał(a): > Which is removing the parameter from the object, I would have expected that > this return a modified copy? Yes, you are right. > Just wondering the intentions of the class, and if this should be logged as a > bug? I would say it's a bug. R

Is HttpParameters Supposed to be Immutable

2018-08-21 Thread Paul Zepernick
I was doing some work on a custom interceptor that was working with the HttpParameters class. At first glance, it appears that it is supposed to be immutable based on some of the exceptions thrown for implementations of Map methods, for example: @Override public Parameter put(String key