Re: From ??? Re: From ??? Re: Checkbox tag new attribute submitUnchecked

2022-11-09 Thread Britta Katzenbach
Thanks! I entered the ticket: https://issues.apache.org/jira/browse/WW-5260 As I described in the ticket, the best solution would be to stick with default value false, but offer a solution to change it via configuration. Kind regards, Britta Katzenbach __

Re: From ??? Re: From ??? Re: Checkbox tag new attribute submitUnchecked

2022-11-09 Thread Lukasz Lenart
śr., 9 lis 2022 o 14:59 Britta Katzenbach napisał(a): > > Yes, I see the discussion in the pull request. It definitely is not backward > compatible. As in the old simple checkbox template (struts 2.5), you always > generate the hidden input field. In struts 6 you added <#if > parameters.submitU

Re: From ??? Re: From ??? Re: Checkbox tag new attribute submitUnchecked

2022-11-09 Thread Britta Katzenbach
Yes, I see the discussion in the pull request. It definitely is not backward compatible. As in the old simple checkbox template (struts 2.5), you always generate the hidden input field. In struts 6 you added <#if parameters.submitUnchecked!false>, so the hidden field is only generate if you set

Re: From ??? Re: Checkbox tag new attribute submitUnchecked

2022-11-09 Thread Burton Rhodes
Sure thing. When this feature was implemented, I remember making sure we didn't break backward compatibility. Strange that you are seeing this "break" during your upgrade. Perhaps Lukasz can chime in. Pull Request for SubmitUnchecked https://github.com/apache/struts/pull/169 -- Original

Re: From ??? Re: Checkbox tag new attribute submitUnchecked

2022-11-09 Thread Britta Katzenbach
Hi Burton, Thanks for the quick answer and the description! I was hoping for a solution to set the default value via the configuration, but it is ok. We prefer to set the attribute in all our checkboxes in this case, because otherwise we would need to maintain the template. It would be nice if

Re: Checkbox tag new attribute submitUnchecked

2022-11-09 Thread Burton Rhodes
You would just need to override the checkbox.ftl template. Below is a line from the Struts template/simple/checkbox.ftl file. You'll notice the line below defaults to false if "submitUnchecked" is not present. <#if parameters.submitUnchecked!false> Change to: <#if parameters.submitUnchecked!t

Checkbox tag new attribute submitUnchecked

2022-11-09 Thread Britta Katzenbach
Hi, We are migrating from struts 2.5 to 6.0.3. You have implemented the new tag attribute submitUnchecked in the checkbox. The default value is false. Is there any way to set the attribute default value to true? Best regards, Britta Britta Katzenbach _