Re: Java 11 support

I agree with Lukasz. That's the way to do it. Am 24.01.2019 um 07:58 schrieb Lukasz Lenart: > śr., 23 sty 2019 o 15:49 Yasser Zamani napisał(a): >> I'm not sure if I get your point correctly but I didn't change `target` in >> [1]. >> >> If you meant the user's itself java 11 compiled classes str

Re: Java 11 support

śr., 23 sty 2019 o 15:49 Yasser Zamani napisał(a): > I'm not sure if I get your point correctly but I didn't change `target` in > [1]. > > If you meant the user's itself java 11 compiled classes structure, to double > verify if it works, with [1]'s local branch with a few local changes into > s

RE: Java 11 support

>-Original Message- >From: Lukasz Lenart >Sent: Wednesday, January 23, 2019 4:59 PM >To: Struts Users Mailing List >Subject: Re: Java 11 support > >śr., 23 sty 2019 o 14:10 Yasser Zamani napisał(a): >> >I would start with detecting a proper Java version first. The >> >additional consta

Re: Java 11 support

śr., 23 sty 2019 o 14:10 Yasser Zamani napisał(a): > >I would start with detecting a proper Java version first. The additional > >constant > >will introduce unneeded burden for users to control it. > > Fortunately it seems it isn't required. Locally all tests are passing here > with all java ver

RE: Java 11 support

>-Original Message- >From: Lukasz Lenart >Sent: Wednesday, January 23, 2019 11:34 AM >To: Struts Users Mailing List >Subject: Re: Java 11 support > >śr., 23 sty 2019 o 08:35 Yasser Zamani napisał(a): >> I would prefer to allow user to optionally override the default Opcodes.ASM5 >via a

Re: Java 11 support

śr., 23 sty 2019 o 08:35 Yasser Zamani napisał(a): > I would prefer to allow user to optionally override the default Opcodes.ASM5 > via a constant in struts.xml e.g. value=" Opcodes.ASM7"/>, Or more better, to think if it's possible to > determine it at runtime via user's runtime context e.g. j