Re: AW: AW: Struts 1 and thread safety

2010-09-18 Thread Chris Mawata
On 9/18/2010 8:36 AM, Norbert Hirneisen wrote: Just another question regarding this context: the original code has been written by a colleague. Now I´m intrigued if setting the execute-Method in the base class within a synchronized block makes sense ?! As far as I´m understanding the action cla

Re: Struts 2.2.1 gives There is no Action mapped for namespace / and action name .

2010-09-18 Thread Dave Newton
Check the logs, and it may depend on whether or not devMode is on. On Sat, Sep 18, 2010 at 12:12 PM, Dean Schulze wrote: > > Turns out that the problem was that my JSPs were in the wrong directory > (WEB-INF/ instead of web/). That's a strange error message to give in that > circumstance. Anywa

Re: Struts 2.2.1 gives There is no Action mapped for namespace / and action name .

2010-09-18 Thread Dean Schulze
Turns out that the problem was that my JSPs were in the wrong directory (WEB-INF/ instead of web/).  That's a strange error message to give in that circumstance.  Anyway, problem solved. --- On Fri, 9/17/10, Dave Newton wrote: From: Dave Newton Subject: Re: Struts 2.2.1 gives There is no Ac

Re: AW: Struts 1 and thread safety

2010-09-18 Thread Dave Newton
Yes, synchronizing in this way could potentially be bad. On Sat, Sep 18, 2010 at 8:36 AM, Norbert Hirneisen wrote: > Just another question regarding this context: > > the original code has been written by a colleague. > Now I´m intrigued if setting the execute-Method in the base class within a >

AW: AW: Struts 1 and thread safety

2010-09-18 Thread Norbert Hirneisen
Just another question regarding this context: the original code has been written by a colleague. Now I´m intrigued if setting the execute-Method in the base class within a synchronized block makes sense ?! As far as I´m understanding the action classes behave like servlets and multiple request c

AW: AW: Struts 1 and thread safety

2010-09-18 Thread Norbert Hirneisen
Thanks for the hint to ThreadLocals. I´m using the projectId in the subclassed action classes to identify a project, generate project-related URLs and to query the database for project-related data. I´m needing the projectId in nearly every subclassed action. It would be very convenient to retr

Re: AW: Struts 1 and thread safety

2010-09-18 Thread Dave Newton
No, I meant actual ThreadLocals, but what you're saying would work too. The best way to go about doing it depends on what's being done in the subclasses. Dave On Sat, Sep 18, 2010 at 7:53 AM, Norbert Hirneisen wrote: > Thanks, Dave. > > Using the data local means to call > long projectId = Pro

AW: AW: Struts 1 and thread safety

2010-09-18 Thread Norbert Hirneisen
Thanks, Dave. Using the data local means to call long projectId = Project.getIdFromRequest(request); in every subclass because there is no thread-safe way to use a class field in the super-class ? Would it be thread-safe to use a local variable in the super-class and store the data in the sess

Re: AW: Struts 1 and thread safety

2010-09-18 Thread Dave Newton
No, it's not thread safe. Actions should be treated like servlets in this regard, and designed better. Consider either passing the required data around, or using thread locals. Dave On Sep 18, 2010 6:42 AM, "Norbert Hirneisen" wrote: > Nobody here who can help ? > >> -Ursprüngliche Nachrich

AW: Struts 1 and thread safety

2010-09-18 Thread Norbert Hirneisen
Nobody here who can help ? > -Ursprüngliche Nachricht- > Von: Norbert Hirneisen [mailto:no...@s2you.de] > Gesendet: Freitag, 17. September 2010 11:01 > An: user@struts.apache.org > Betreff: Struts 1 and thread safety > > > Hello, > > I have al large Struts 1 application with a modified