Re: 4.0.0 Contribution: Javadoc Cleanup

2018-07-21 Thread Andreas Beeker
Hi Eliot, as always: "just do it" ... please provide your patches in a reasonable size (e.g. by package) If they make sense and we have the impression that you'll stick with the project, we usually invite developers to become committers - especially as the hwpf/xwpf apis are a bit in dire strait

Re: General Mechanism in WXPF Code for Managing CT IDs?

2018-07-21 Thread Mark Murphy
Since footnotes and endnotes have essentially the same functionality, it might be good to create a single abstract class that handles the common bits. Then it should be trivial to extend the process for endnotes. On Sat, Jul 21, 2018, 7:10 AM Eliot Kimber wrote: > Reviewing the OOXML specs it is

4.0.0 Contribution: Javadoc Cleanup

2018-07-21 Thread Eliot Kimber
As both a technical writer by training and as a user of the POI XWPDF API I'd like to make a pass over the javadocs to make sure every public class and method has an appropriate and accurate description and add usage tips to classes as appropriate. That’s all the XWPF* classes and anything els

Re: General Mechanism in WXPF Code for Managing CT IDs?

2018-07-21 Thread Eliot Kimber
Reviewing the OOXML specs it is the case that the current XWPF API does not accommodate end notes as it should. There needs to be separate XWPFEndnotes and XWPFEndnote classes and document- and section-level code to create and manage them. I can take that on as a separate activity once we're ha

Re: General Mechanism in WXPF Code for Managing CT IDs?

2018-07-21 Thread Eliot Kimber
I'll double check all the relevant methods in the footnote and footnotes classes. At the moment I'm focused on bottom-of-the-page notes because that's what I need to generate in the context of my client work that is motivating these updates but definitely need to make sure end notes are properly

Re: Contributor Question: How Best to Create Pull Request Using a git-svn Clone?

2018-07-21 Thread Dominik Stadler
Hi, Unfortunately git-svn repositories are not compatible with the github version due to different meta-data in the commits, so you cannot easily connect both. With git-svn you need to create patches and ideally upload them to an issue in the bugzilla issue tracker, see https://poi.apache.org/deve