Re: General Mechanism in WXPF Code for Managing CT IDs?

2018-07-20 Thread Mark Murphy
Have you looked through XWPFFootnote and XWPFFootnotes? XWPFDocument has some code to create footnotes as well, but it appears that endnotes are incorrectly references without having a class of thier own. Maybe you should try correcting these. On Fri, Jul 20, 2018 at 11:47 AM Eliot Kimber wrote:

RE: General Mechanism in WXPF Code for Managing CT IDs?

2018-07-20 Thread Murphy, Mark
In fact, I think it would be good to change the TableCell behavior before 4.0.0 goes live as that is a breaking change. -Original Message- From: Murphy, Mark [mailto:murphym...@metalexmfg.com] Sent: Friday, July 20, 2018 3:52 PM To: 'POI Users List' Subject: RE: General Mechanism in WXP

RE: Contributor Question: How Best to Create Pull Request Using a git-svn Clone?

2018-07-20 Thread Murphy, Mark
It depends on who goes about reviewing your changes. Most don't care, PJ prefers a git pull request. I generally do my real work in svn, and test stuff in a git clone. -Original Message- From: Eliot Kimber [mailto:ekim...@contrext.com] Sent: Friday, July 20, 2018 12:00 PM To: POI Users

RE: General Mechanism in WXPF Code for Managing CT IDs?

2018-07-20 Thread Murphy, Mark
Those places that have this behavior are being adjusted as I get to them. So let's not create extra work for later. -Original Message- From: Eliot Kimber [mailto:ekim...@contrext.com] Sent: Friday, July 20, 2018 11:22 AM To: POI Users List Subject: Re: General Mechanism in WXPF Code for

Contributor Question: How Best to Create Pull Request Using a git-svn Clone?

2018-07-20 Thread Eliot Kimber
I've done my work in a git-svn clone of the project, but reviewing the contributor guidance it's not clear to me how best to create a pull request or patch submission in this case. Maybe I should have used the read-only git repo on GitHub? Thanks, E. -- Eliot Kimber http://contrext.com -

Re: General Mechanism in WXPF Code for Managing CT IDs?

2018-07-20 Thread Eliot Kimber
On IDs, since the ID space is just footnotes, I'm just using the number of footnotes in the Footnotes' footnote list to generate the next available ID. There didn't seem to be a need for more sophistication than that. Cheers, E. -- Eliot Kimber http://contrext.com On 7/20/18, 11:06 AM, "Ma

Re: General Mechanism in WXPF Code for Managing CT IDs?

2018-07-20 Thread Eliot Kimber
I agree that having to treat the first paragraph separately is annoying, however, there are already several classes that do that (e.g., XWPFTableRow, which creates a new cell and that cell has a paragraph), so unless we modify them all to not create an initial child object, it seems like consist

Re: General Mechanism in WXPF Code for Managing CT IDs?

2018-07-20 Thread Mark Murphy
According to the spec, the id's for footnotes and end notes are unique to the note type (footnote or end note). You may want to create this so that it can handle footnotes or end notes as there are only cosmetic differences between the two. Similar to header/footer. Id's should be handled internall

Re: General Mechanism in WXPF Code for Managing CT IDs?

2018-07-20 Thread pj.fanning
We don't seem to have set ids explicitly normally -- Sent from: http://apache-poi.1045710.n5.nabble.com/POI-User-f2280730.html - To unsubscribe, e-mail: user-unsubscr...@poi.apache.org For additional commands, e-mail: user-h...

General Mechanism in WXPF Code for Managing CT IDs?

2018-07-20 Thread Eliot Kimber
For footnotes I need to set a unique ID on each newly-created getCTFtnEdn. In my personal code I was maintaining my own global ID counter that I used to set IDs on things. However, I'm not finding a similar mechanism in the POI code--is there one or is there a reliable technique for constructin