Re: Fixed bug in PMetaDataImpl

2015-10-02 Thread James Heather
Commit message updated. On 02/10/15 17:02, James Taylor wrote: Patch looks great - thanks so much, James. Would you mind prefixing the commit message with "PHOENIX-2256" as that's what ties the pull to the JIRA? I'll get this committed today. James On Fri, Oct 2, 2015 at 7:34 AM, James H

Re: Fixed bug in PMetaDataImpl

2015-10-02 Thread Cody Marcel
I think that's a duplicate bug. Can we consolidate them? https://issues.apache.org/jira/browse/PHOENIX-2172 On Fri, Oct 2, 2015 at 9:02 AM, James Taylor wrote: > Patch looks great - thanks so much, James. Would you mind prefixing the > commit message with "PHOENIX-2256" as that's what ties the

Re: Fixed bug in PMetaDataImpl

2015-10-02 Thread James Taylor
Patch looks great - thanks so much, James. Would you mind prefixing the commit message with "PHOENIX-2256" as that's what ties the pull to the JIRA? I'll get this committed today. James On Fri, Oct 2, 2015 at 7:34 AM, James Heather wrote: > Hi all (@James T in particular), > > I've submitte

Fixed bug in PMetaDataImpl

2015-10-02 Thread James Heather
Hi all (@James T in particular), I've submitted a pull request to fix the bug I reported in https://issues.apache.org/jira/browse/PHOENIX-2256 concerning a failing unit test in Java 8. It was a genuine bug in PMetaDataImpl that just happened to sneak through the tests in Java 7 but not Java