Re: [DISCUSS] Breaking JSON response body change in OpenMeetings Json/Rest API 7.0.0

Just a few points to this discussion I can log all other methods and detailed content as well > => It is _not_ about application logs. It's about access_log and for example every router in your LAN or WAN can log the full URL. You can quite simply enable the router log in your local network and si

Re: [DISCUSS] Breaking JSON response body change in OpenMeetings Json/Rest API 7.0.0

Hello Seba, please see my comments inline On Fri, 24 Sept 2021 at 04:55, seba.wag...@gmail.com wrote: > Also just to reiterate: This is not to say "this API is bad" it is just > that over the course of the last 10 years REST has changed. As I tried to > explain in my previous email. > understo

Re: [DISCUSS] Breaking JSON response body change in OpenMeetings Json/Rest API 7.0.0

Also just to reiterate: This is not to say "this API is bad" it is just that over the course of the last 10 years REST has changed. As I tried to explain in my previous email. And also: I am happy to lead and spend my time on this activity around introducing v2 and address the above issues. AS wel

Re: [DISCUSS] Breaking JSON response body change in OpenMeetings Json/Rest API 7.0.0

> > *So far I don't see how the existence of SOAP complicates things :)* => See below list of what a potential v2 of the Rest API could/should fix. I don't see how this can be fixed while keeping SOAP and REST in the same class definition: *Security - 2.4. Never expose sensitive information on UR

Re: [DISCUSS] Breaking JSON response body change in OpenMeetings Json/Rest API 7.0.0

On Thu, 23 Sept 2021 at 04:47, seba.wag...@gmail.com wrote: > Hi all! > > I think we may try to solve too many things at the same time in this > discussion. But also in our API. It just seems things are a bit too tightly > coupled. > > For example: > *We can't change/update REST methods, cause th

Re: [DISCUSS] Breaking JSON response body change in OpenMeetings Json/Rest API 7.0.0

Very good, as long as changes will not affect/impact all of those invested in OM of resources, and will not, all of a sudden, things will not work on a supposedly simple upgrade. Ali On 9/23/21 12:47 AM, seba.wag...@gmail.com wrote: Hi all! I think we may try to solve too many things at the

Re: [DISCUSS] Breaking JSON response body change in OpenMeetings Json/Rest API 7.0.0

Hi all! I think we may try to solve too many things at the same time in this discussion. But also in our API. It just seems things are a bit too tightly coupled. For example: *We can't change/update REST methods, cause they affect SOAP calls. Currently we have a just a single class that does both

Re: [DISCUSS] Breaking JSON response body change in OpenMeetings Json/Rest API 7.0.0

Can you not employ an extra programmer? On 22/09/2021 13:24, Maxim Solodovnik wrote: On Wed, 22 Sept 2021 at 19:20, Ali Alhaidary mailto:ali.alhaid...@the5stars.org>> wrote: On 9/22/21 3:14 PM, Maxim Solodovnik wrote: I only can do manual testing here :( What is manual testin

Re: [DISCUSS] Breaking JSON response body change in OpenMeetings Json/Rest API 7.0.0

On 9/22/21 3:24 PM, Maxim Solodovnik wrote: On Wed, 22 Sept 2021 at 19:20, Ali Alhaidary mailto:ali.alhaid...@the5stars.org>> wrote: On 9/22/21 3:14 PM, Maxim Solodovnik wrote: I only can do manual testing here :( What is manual testing? I'm installing everything setting up

Re: [DISCUSS] Breaking JSON response body change in OpenMeetings Json/Rest API 7.0.0

On Wed, 22 Sept 2021 at 19:20, Ali Alhaidary wrote: > > On 9/22/21 3:14 PM, Maxim Solodovnik wrote: > > I only can do manual testing here :( > > What is manual testing? > I'm installing everything setting up integration and do clicking :))) > IMO these changes (if we will be able to do them) w

Re: [DISCUSS] Breaking JSON response body change in OpenMeetings Json/Rest API 7.0.0

On 9/22/21 3:14 PM, Maxim Solodovnik wrote: I only can do manual testing here :( What is manual testing? IMO these changes (if we will be able to do them) worth to be done what is IMO ? Why I raise some old design issues: we can do changes now and let the API unchanged for another several ye

Re: [DISCUSS] Breaking JSON response body change in OpenMeetings Json/Rest API 7.0.0

I only can do manual testing here :( IMO these changes (if we will be able to do them) worth to be done Why I raise some old design issues: we can do changes now and let the API unchanged for another several years :))) On Wed, 22 Sept 2021 at 19:09, Ali Alhaidary wrote: > The issue here is that,

Re: [DISCUSS] Breaking JSON response body change in OpenMeetings Json/Rest API 7.0.0

The issue here is that, It is a lot of work, and, a lot of testing that follows. We are not a direct API users, however, moodle plugin is. Along the road, things could break in such change. So, if you see this change is the the way forward, I am in with as usual a dedicated production server fo

Re: [DISCUSS] Breaking JSON response body change in OpenMeetings Json/Rest API 7.0.0

These changes are only being discussed Nothing is broken, yet : we can @Deprecate these old methods and/or move it to some prefixed URL so API users will need to change base URL from https://localhost:5443/openmeetings to https://localhost:5443/openmeetings/v1 On Wed, 22 Sept 2021 at 13:14, se

Re: [DISCUSS] Breaking JSON response body change in OpenMeetings Json/Rest API 7.0.0

On Wed, 22 Sept 2021 at 13:11, seba.wag...@gmail.com wrote: > @Maxim Solodovnik > The strange thing about those POST requests is that its a @FormParam. And > not just a simple request post body. > Well @FormParam was used due to this was the option I was able to find :))) My goal was to be able

Re: [DISCUSS] Breaking JSON response body change in OpenMeetings Json/Rest API 7.0.0

This would be good for me. I have customized the moodle  module and have just about every API working. On 22/09/2021 07:13, seba.wag...@gmail.com wrote: @Ali Alhaidary The other alternative to fix the issue AND make it backwards compatible would be to have

Re: [DISCUSS] Breaking JSON response body change in OpenMeetings Json/Rest API 7.0.0

@Ali Alhaidary The other alternative to fix the issue AND make it backwards compatible would be to have a /v2 version of the API So all endpoints would be duplicated to have version /v2 of the API (with maybe some other fixes) and the current API stays the same. But would not receive any improvem

Re: [DISCUSS] Breaking JSON response body change in OpenMeetings Json/Rest API 7.0.0

@Maxim Solodovnik The strange thing about those POST requests is that its a @FormParam. And not just a simple request post body. Those methods are POST Methods. So by definition the payload should be sent in the POST request body. Makes sense? :) However a POST Body, only has 1 Body. You can NOT

Re: [DISCUSS] Breaking JSON response body change in OpenMeetings Json/Rest API 7.0.0

We are using OM in production with moodle front end, we can not tolerate downtime neither with OM or its plugin (that needs fixing, but living with), and to tell you the truth, I do not see it as 'broken' from that angle. So my answer is B. Ali On 9/22/21 2:10 AM, seba.wag...@gmail.com wrote

Re: [DISCUSS] Breaking JSON response body change in OpenMeetings Json/Rest API 7.0.0

On Wed, 22 Sept 2021 at 12:37, seba.wag...@gmail.com wrote: > I'm +1 for the change :) > => OK > > right now we have `JSON.stringify` [1] in some places, and NOT in some > others. I would completely get rid of it :( > => You mean from the request parameter or response parameters ? > it's in requ

Re: [DISCUSS] Breaking JSON response body change in OpenMeetings Json/Rest API 7.0.0

I'm +1 for the change :) => OK right now we have `JSON.stringify` [1] in some places, and NOT in some others. I would completely get rid of it :( => You mean from the request parameter or response parameters ? Thanks Seb Sebastian Wagner Director Arrakeen Solutions, OM-Hosting.com http://arrake

Re: [DISCUSS] Breaking JSON response body change in OpenMeetings Json/Rest API 7.0.0

I'm +1 for the change :) And I propose to check the current REST API to be clearer for ex. right now we have `JSON.stringify` [1] in some places, and NOT in some others I would completely get rid of it :( this particular change is small and will affect 1-2 lines of code in Moodle plugin :) [1] h

Re: [DISCUSS] Breaking JSON response body change in OpenMeetings Json/Rest API 7.0.0

It is broken. The problem is the fix will be a breaking change that will require 3rd party integration code to be fixed. Not a big fix, but a fix. Eg the Moodle Plugin requires some minor changes. The workaround is to write some additional wrapper code to make it backwards compatible. Which is als

Re: [DISCUSS] Breaking JSON response body change in OpenMeetings Json/Rest API 7.0.0

Hi, We have an old saying 'If it is not broken, do not fix it' ;-) Ali On 9/22/21 12:46 AM, seba.wag...@gmail.com wrote: Hi, as discussed in the comments section in https://github.com/apache/openmeetings/commit/4daf7c1f53738cd786dc976114cc5278b4f05f4f#comments

[DISCUSS] Breaking JSON response body change in OpenMeetings Json/Rest API 7.0.0

Hi, as discussed in the comments section in https://github.com/apache/openmeetings/commit/4daf7c1f53738cd786dc976114cc5278b4f05f4f#comments we would like to propose a breaking change for the OpenMeetings Json/Rest API in v7.0.0 Problem: JSON response wrapping Currently CXF-RS is configured to w