Re: [DISCUSS] Breaking JSON response body change in OpenMeetings Json/Rest API 7.0.0

2021-09-21 Thread Daniel Baker
This would be good for me. I have customized the moodle  module and have just about every API working. On 22/09/2021 07:13, seba.wag...@gmail.com wrote: @Ali Alhaidary The other alternative to fix the issue AND make it backwards compatible would be to have

Re: [DISCUSS] Breaking JSON response body change in OpenMeetings Json/Rest API 7.0.0

2021-09-21 Thread seba.wag...@gmail.com
@Ali Alhaidary The other alternative to fix the issue AND make it backwards compatible would be to have a /v2 version of the API So all endpoints would be duplicated to have version /v2 of the API (with maybe some other fixes) and the current API stays the same. But would not receive any improvem

Re: [DISCUSS] Breaking JSON response body change in OpenMeetings Json/Rest API 7.0.0

2021-09-21 Thread seba.wag...@gmail.com
@Maxim Solodovnik The strange thing about those POST requests is that its a @FormParam. And not just a simple request post body. Those methods are POST Methods. So by definition the payload should be sent in the POST request body. Makes sense? :) However a POST Body, only has 1 Body. You can NOT

Re: [DISCUSS] Breaking JSON response body change in OpenMeetings Json/Rest API 7.0.0

2021-09-21 Thread Ali Alhaidary
We are using OM in production with moodle front end, we can not tolerate downtime neither with OM or its plugin (that needs fixing, but living with), and to tell you the truth, I do not see it as 'broken' from that angle. So my answer is B. Ali On 9/22/21 2:10 AM, seba.wag...@gmail.com wrote

Re: [DISCUSS] Breaking JSON response body change in OpenMeetings Json/Rest API 7.0.0

2021-09-21 Thread Maxim Solodovnik
On Wed, 22 Sept 2021 at 12:37, seba.wag...@gmail.com wrote: > I'm +1 for the change :) > => OK > > right now we have `JSON.stringify` [1] in some places, and NOT in some > others. I would completely get rid of it :( > => You mean from the request parameter or response parameters ? > it's in requ

Re: [DISCUSS] Breaking JSON response body change in OpenMeetings Json/Rest API 7.0.0

2021-09-21 Thread seba.wag...@gmail.com
I'm +1 for the change :) => OK right now we have `JSON.stringify` [1] in some places, and NOT in some others. I would completely get rid of it :( => You mean from the request parameter or response parameters ? Thanks Seb Sebastian Wagner Director Arrakeen Solutions, OM-Hosting.com http://arrake

Re: [DISCUSS] Breaking JSON response body change in OpenMeetings Json/Rest API 7.0.0

2021-09-21 Thread Maxim Solodovnik
I'm +1 for the change :) And I propose to check the current REST API to be clearer for ex. right now we have `JSON.stringify` [1] in some places, and NOT in some others I would completely get rid of it :( this particular change is small and will affect 1-2 lines of code in Moodle plugin :) [1] h

Re: [DISCUSS] Breaking JSON response body change in OpenMeetings Json/Rest API 7.0.0

2021-09-21 Thread seba.wag...@gmail.com
It is broken. The problem is the fix will be a breaking change that will require 3rd party integration code to be fixed. Not a big fix, but a fix. Eg the Moodle Plugin requires some minor changes. The workaround is to write some additional wrapper code to make it backwards compatible. Which is als

Re: [DISCUSS] Breaking JSON response body change in OpenMeetings Json/Rest API 7.0.0

2021-09-21 Thread Ali Alhaidary
Hi, We have an old saying 'If it is not broken, do not fix it' ;-) Ali On 9/22/21 12:46 AM, seba.wag...@gmail.com wrote: Hi, as discussed in the comments section in https://github.com/apache/openmeetings/commit/4daf7c1f53738cd786dc976114cc5278b4f05f4f#comments

[DISCUSS] Breaking JSON response body change in OpenMeetings Json/Rest API 7.0.0

2021-09-21 Thread seba.wag...@gmail.com
Hi, as discussed in the comments section in https://github.com/apache/openmeetings/commit/4daf7c1f53738cd786dc976114cc5278b4f05f4f#comments we would like to propose a breaking change for the OpenMeetings Json/Rest API in v7.0.0 Problem: JSON response wrapping Currently CXF-RS is configured to w

Re: OM and Media server separated-recording issue

2021-09-21 Thread Jeffry Johnson
I am working on a fresh install using mariadb instead of the Oracle sql db we've been using. Just running into some issues with internet access for the servers in installing on. Waiting on our network team to open it up. I will let you know asap what my findings are On Tue, Sep 21, 2021, 10:16 Alv

Re: OM and Media server separated-recording issue

2021-09-21 Thread Alvaro
I just made a fresh installation of Centos 7 and installed OM 6.1.0 following the tutorial. Testing Chrome 93, and later Chromium 90 as user "A", and Chrome 87 and 93, Chromium 92, Safari 14.1.2 and Yandex 21.6 successively as user "B", al them show cams and makes recordings rightly. Firefox brin