Re: 回复: Round function display

2013-04-02 Thread Mark Grover
Hi Chenchun, Sorry for the super delayed response. Ideally, I would have given you permissions to edit the wiki but I don't have the privileges to do so. For now, I have edited the wiki on your behalf and added the FAQ section on the page with your suggestions: https://cwiki.apache.org/confluence/d

回复: Round function display

2013-03-25 Thread chenchun
Hi mark, I read the the wiki of PhabricatorCodeReview https://cwiki.apache.org/confluence/display/Hive/PhabricatorCodeReview and send a review https://reviews.facebook.net/D9687 for the issue. In this process I encountered a few problems with arc, the code of arc cloned from github is not in t

回复: Round function display

2013-03-17 Thread chenchun
Hi Mark, Sure, I have add the attachment to the issue and send a mail to apply to become the contributor to the JIRA. Thanks. regards, chenchun 在 星期一, 18 3月, 2013,12:32 AM,Mark Grover 写道: > Hi Chenchun, > Can you please: > 1. Send a separate email to this same mailing list to add you as a >

Re: 回复: Round function display

2013-03-17 Thread Mark Grover
Hi Chenchun, Can you please: 1. Send a separate email to this same mailing list to add you as a contributor to the JIRA? I don't have credentials to do so and seems like other people are not watching this thread:-) 2. Upload this patch to the JIRA? Thanks! Mark On Sat, Mar 16, 2013 at 4:21 AM, ch

回复: Round function display

2013-03-16 Thread chenchun
Hi Mark, I made a patch along with updated tests today, see the attachment. Hope it works. Thanks. regards, chenchun 在 星期五, 15 3月, 2013,10:31 AM,chenchun 写道: > Sorry, it's a bit late last night and it's funny to realize that we works for > the whole daytime and you guys just begin at night.

回复: Round function display

2013-03-14 Thread chenchun
Sorry, it's a bit late last night and it's funny to realize that we works for the whole daytime and you guys just begin at night. What a round earth ! Username: chenchun Email: chenchun.f...@gmail.com regards, chenchun 在 星期五, 15 3月, 2013,1:01 AM,Mark Grover 写道: > Someone will have to add you

Re: 回复: Round function display

2013-03-14 Thread Mark Grover
Someone will have to add you to the project contributors on JIRA. Could you please share your JIRA account ID and email address? Mark On Thu, Mar 14, 2013 at 9:58 AM, chenchun wrote: > Cool, I'd like to steal it from you. I'd like to get a few days to solve it > but how I can assigne it to me ?

回复: Round function display

2013-03-14 Thread chenchun
Cool, I'd like to steal it from you. I'd like to get a few days to solve it but how I can assigne it to me ? regards, chenchun 在 星期四, 14 3月, 2013,10:20 PM,Mark Grover 写道: > > round function. > I created https://issues.apache.org/jira/browse/HIVE-4174 to track > this. It's presently assigned

Re: Round function display

2013-03-14 Thread Mark Grover
Hi chenchun, About the second part of your question, I agree that we should change it. I checked MySQL and it returns the same type as was sent to the round function. I created https://issues.apache.org/jira/browse/HIVE-4174 to track this. It's presently assigned to me but if you like to contribute

Round function display

2013-03-14 Thread chenchun
Hi, I have a question about HIVE-3675 NaN does not work correctly for round(n). The issue did solve the NaN problem, but the hql below result in a different display with hive0.10. I checked the code UDFRound.java, found the function "LongWritable evaluate(DoubleWritable n)" changed to "DoubleWrit