Re: HiveHistory and HiveHistoryViewer

2012-12-17 Thread Mark Grover
Qiang, Good point. Uploaded a new patch. Thanks! On Mon, Dec 17, 2012 at 9:14 PM, Qiang Wang wrote: > "HiveHistory.parseHiveHistory use BufferedReader.readLine which takes '\n', > '\r', '\r\n' as line delimiter to parse history file" > > And clients may be on mac, which takes '\r' as line delimit

Re: HiveHistory and HiveHistoryViewer

2012-12-17 Thread Qiang Wang
"HiveHistory.parseHiveHistory use BufferedReader.readLine which takes '\n', '\r', '\r\n' as line delimiter to parse history file" And clients may be on mac, which takes '\r' as line delimiter So I think '\r' should also be replaced with space in HiveHistory.log, so that HiveHistory.parseHiveHist

Re: HiveHistory and HiveHistoryViewer

2012-12-17 Thread Mark Grover
Looks like a bug to me. This is the original JIRA that introduced this change: https://issues.apache.org/jira/browse/HIVE-176 I don't think back in the day, we really cared about clients being on windows. In any case, thanks for filing the JIRA, I have uploaded a patch which I think doesn't break

Re: HiveHistory and HiveHistoryViewer

2012-12-17 Thread Qiang Wang
anybody has an idea about this ? https://issues.apache.org/jira/browse/HIVE-3810 2012/12/16 Qiang Wang > glad to receive your reply! > > here is my point: > Firstly, I think HiveHistoryViewer is inconsistent with HiveHistory. > Secondly, hive server may be deloyed on linux, but client can be

Re: HiveHistory and HiveHistoryViewer

2012-12-16 Thread Qiang Wang
glad to receive your reply! here is my point: Firstly, I think HiveHistoryViewer is inconsistent with HiveHistory. Secondly, hive server may be deloyed on linux, but client can be anywhere. hql from client will be logged into history file and hql may contails '\r' 2012/12/16 afancy > I don\t t

Re: HiveHistory and HiveHistoryViewer

2012-12-16 Thread afancy
I don\t think it is a bug. If the program in hive writes logs to HiveHistory.log using '\n' to indicate the end of a line. Then, it is OK to use *val = val.replace('\n', ' ');. Anyway, ** new line depends what on your OS: Hive is typically deployed