Re: File Channel Backup Checkpoints are I/O Intensive

2014-07-02 Thread Abraham Fine
Hi Brock and Hari- I was just wondering if either of you had a chance to take a look at the patch and if there is anything I can do to improve it. Thanks, Abe -- Abraham Fine | Software Engineer (516) 567-2535 BrightRoll, Inc. | Smart Video Advertising | www.brightroll.com On Wed, Jun 11, 201

Re: File Channel Backup Checkpoints are I/O Intensive

2014-07-02 Thread Hari Shreedharan
Hi Abraham, In general, the patch looks good. Can you add a couple of tests - * Original checkpoint is uncompressed, config changes to compress checkpoint - does the file channel restart from original checkpoint? are new checkpoints compressed? * Compressed checkpoint, config changes to not compre

Re: File Channel Backup Checkpoints are I/O Intensive

2014-07-02 Thread Abraham Fine
Hari- I added the new tests and created a new revision to my patch. https://issues.apache.org/jira/secure/attachment/12653728/compress_backup_checkpoint_new_tests.patch Thanks, Abe -- Abraham Fine | Software Engineer (516) 567-2535 BrightRoll, Inc. | Smart Video Advertising | www.brightroll.co

Re: File Channel Backup Checkpoints are I/O Intensive

2014-07-02 Thread Hari Shreedharan
Thanks a lot. I will take a look at this tomorrow or early next week. On Wed, Jul 2, 2014 at 5:29 PM, Abraham Fine wrote: > Hari- > > I added the new tests and created a new revision to my patch. > > > https://issues.apache.org/jira/secure/attachment/12653728/compress_backup_checkpoint_new_test