Re: observedGeneration field in FlinkDeployment

2023-10-09 Thread Tony Chen
I think that a FLIP JIRA should be created to add an `observedGeneration` field to the spec. When I look at other kubernetes APIs, I see the `observedGeneration` field in many of them: https://kubernetes.io/docs/reference/generated/kubernetes-api/v1.26/ On Mon, Sep 11, 2023 at 11:51 AM Tony Chen

Re: observedGeneration field in FlinkDeployment

2023-09-11 Thread Tony Chen
I think it should be fine for now. I can compare the following 2 fields to check if the spec has changed: - metadata.generation: 4 - status.reconciliationStatus.lastStableSpec: '{"resource_metadata": {"metadata": {"generation": 2}' On Sat, Sep 9, 2023 at 2:48 AM Gyula Fóra wrote: > Ac

Re: observedGeneration field in FlinkDeployment

2023-09-08 Thread Gyula Fóra
Actually, I just realized, the last fully reconciled spec generation should be written into a metadata JSON inside the lastReconciledSpec. So this is already available. For example: lastReconciledSpec: '{"spec":{...},"resource_metadata":{"apiVersion":" flink.apache.org/v1beta1 ","metadata":{"gener

Re: observedGeneration field in FlinkDeployment

2023-09-08 Thread Gyula Fóra
Hi! The lastReconciledSpec field serves similar purpose . We also use the generation in parts of the logic but not generically as observed generation . Could you give an example where this would be useful in addition to what we already have? Thanks Gyula On Sat, 9 Sep 2023 at 02:17, Tony Chen w

observedGeneration field in FlinkDeployment

2023-09-08 Thread Tony Chen
Hi Flink Community, I noticed that there is no status.observedGeneration field in the FlinkDeployment spec. The closest field to this is status.reconciliationStatus.lastReconciledSpec. Are there plans to add the observedGeneration field in the spec? This field will be helpful in detecting changes