Re: merge implementation in count distinct

2020-02-10 Thread Jark Wu
Hi Fanbin, Thanks for reporting this. I think you are right, the implementation is not correct. I have created a JIRA issue [1] to fix this. Btw, the CountDistinctWithMerge in blink planner is implemented correctly [2]. Best, Jark [1]: https://issues.apache.org/jira/browse/FLINK-15979 [2]: https

merge implementation in count distinct

2020-02-10 Thread Fanbin Bu
Hi, For the following implementation of merge, https://github.com/apache/flink/blob/0ab1549f52f1f544e8492757c6b0d562bf50a061/flink-table/flink-table-planner/src/test/java/org/apache/flink/table/runtime/utils/JavaUserDefinedAggFunctions.java#L224 what if acc has the some keys in mergeAcc? the merg