Re: custom metrics in elasticsearch ActionRequestFailureHandler

2021-12-03 Thread Lars Bachmann
Hi Alexander, yes in the first iteration the use case is to get visibility on failed ES requests. Usually we expose metrics to count failures and integrate them into dashboards and setup alerting rules which fire in case they hit a certain threshold. In not Flink based applications which index

Re: custom metrics in elasticsearch ActionRequestFailureHandler

2021-12-03 Thread Alexander Preuß
Hi Lars, What is your use case for the failure handler, just collecting metrics? We want to remove the configurable failure handler in the new Sink API implementation of the Elasticsearch connector in Flink 1.15 because it can be a huge footgun with regards to delivery guarantees. Best Regards, A

Re: custom metrics in elasticsearch ActionRequestFailureHandler

2021-12-02 Thread Lars Bachmann
Hi David, Thanks for the reply. I think especially in an error/failure handler metrics are important in order to have proper monitoring/alerting in such cases. Would be awesome if this could be added to Flink at some point :). Regards, Lars > Am 02.12.2021 um 18:13 schrieb David Morávek : >

Re: custom metrics in elasticsearch ActionRequestFailureHandler

2021-12-02 Thread David Morávek
Hi Lars, quickly looking at the ES connector code, I think you're right and there is no way to do that :( In general I'd say that being able to expose metrics is a valid request. I can imagine having some kind of `RichActionRequestFailureHandler` with `{get|set}RuntimeContext` methods. More or l