Re: Read data from Oracle using Flink SQL API

2020-02-06 Thread Jingsong Li
Hi Flavio, We can just document after support dialect through JDBCTableFactory. Best, Jingsong Lee On Thu, Feb 6, 2020 at 10:54 PM Flavio Pompermaier wrote: > Ok to me, I just want this to be documented in at > https://ci.apache.org/projects/flink/flink-docs-stable/dev/table/connect.html#jdbc

Re: Read data from Oracle using Flink SQL API

2020-02-06 Thread Flavio Pompermaier
Ok to me, I just want this to be documented in at https://ci.apache.org/projects/flink/flink-docs-stable/dev/table/connect.html#jdbc-connector. Do I need to open another JIRA for that? On Thu, Feb 6, 2020 at 11:04 AM Jingsong Li wrote: > Hi Flavio, > > Instead of "TableEnvionment.registerTableSo

Re: Read data from Oracle using Flink SQL API

2020-02-06 Thread Jingsong Li
Hi Flavio, Instead of "TableEnvionment.registerTableSource", we want to drop it in 1.10. I think you can create a JIRA to support pass dialect through JDBCTableFactory. We should support it. What do you think? Best, Jingsong Lee On Thu, Feb 6, 2020 at 6:01 PM Flavio Pompermaier wrote: > Shou

Re: Read data from Oracle using Flink SQL API

2020-02-06 Thread Flavio Pompermaier
Should I open a JIRA to better document how to connect to an RDBMS that has no "out-of-the-box" dialect? I.e. Pass the dialect impl in the TableEnvionment.registerTableSource? On Thu, Feb 6, 2020 at 10:53 AM Jingsong Li wrote: > Hi Bowen, > > JIRA exists: https://issues.apache.org/jira/browse/FL

Re: Read data from Oracle using Flink SQL API

2020-02-06 Thread Jingsong Li
Hi Bowen, JIRA exists: https://issues.apache.org/jira/browse/FLINK-14078 Best, Jingsong Lee On Thu, Feb 6, 2020 at 12:57 PM Bowen Li wrote: > Hi Flavio, > > +1 for adding Oracle (potentially more dbms like SqlServer, etc) to > flink-jdbc. Would you mind open a parent ticket and some subtasks,

Re: Read data from Oracle using Flink SQL API

2020-02-05 Thread Bowen Li
Hi Flavio, +1 for adding Oracle (potentially more dbms like SqlServer, etc) to flink-jdbc. Would you mind open a parent ticket and some subtasks, each one for one to-be-added dbms you've thought of? On Sun, Feb 2, 2020 at 10:11 PM Jingsong Li wrote: > Yes, And I think we should add OracleDiale

Re: Read data from Oracle using Flink SQL API

2020-02-02 Thread Jingsong Li
Yes, And I think we should add OracleDialect,SqlServerDialect,DB2Dialect support too. Best, Jingsong Lee On Sun, Feb 2, 2020 at 5:53 PM Flavio Pompermaier wrote: > Ok thanks for this info! Maybe this could be added to the > documentation..what do you think? > > Il Dom 2 Feb 2020, 08:37 Jingsong

Re: Read data from Oracle using Flink SQL API

2020-02-02 Thread Flavio Pompermaier
Ok thanks for this info! Maybe this could be added to the documentation..what do you think? Il Dom 2 Feb 2020, 08:37 Jingsong Li ha scritto: > Hi Flavio, > > You can use `JDBCTableSource`, and register it from > TableEnvionment.registerTableSource, you need provide > a OracleDialect, maybe jus

Re: Read data from Oracle using Flink SQL API

2020-02-01 Thread Jingsong Li
Hi Flavio, You can use `JDBCTableSource`, and register it from TableEnvionment.registerTableSource, you need provide a OracleDialect, maybe just implement `canHandle` and `defaultDriverName` is OK. Best, Jingsong Lee On Sun, Feb 2, 2020 at 2:42 PM Jark Wu wrote: > Hi Flavio, > > If you want

Re: Read data from Oracle using Flink SQL API

2020-02-01 Thread Jark Wu
Hi Flavio, If you want to adjust the writing statement for Oracle, you can implement the JDBCDialect for Oracle, and pass to the JDBCUpsertTableSink when constructing via `JDBCOptions.Builder#setDialect`. In this way, you don't need to recompile the source code of flink-jdbc. Best, Jark On Fri,