Re: Re: Re: ElasticsearchSink on DataSet

2017-05-11 Thread Flavio Pompermaier
Great! I was just thinking that, in principle, a streaming sink is an extension of a batch one. Am I wrong? This would avoid a lot of code duplication and would improve the overall maintainability.. On Thu, May 11, 2017 at 4:35 AM, wyphao.2007 wrote: > Hi Flavio, I made a PR for this : https://g

Re: Re: ElasticsearchSink on DataSet

2017-05-09 Thread Flavio Pompermaier
Just one note: I took a look at your connector and it doesn't provide any failure handling mechanism that is very useful for us. Maybe it could worth to add ActionRequestFailureHandler as provided now by the current ES streaming connector and introduced by commit https://github.com/apache/flink/com