Re: ElasticsearchSink in Flink 1.4.0 with Elasticsearch 5.2+

2018-01-30 Thread Christophe Jolif
Thanks Chesnay, so if I read it well it shouldn't be too long (at least less time than between regular 1.x releases). On Mon, Jan 29, 2018 at 4:24 PM, Chesnay Schepler wrote: > As of right now there is no specific date, see also > https://flink.apache.org/news/2017/11/22/release-1.4-and-1.5-time

Re: ElasticsearchSink in Flink 1.4.0 with Elasticsearch 5.2+

2018-01-29 Thread Chesnay Schepler
As of right now there is no specific date, see also https://flink.apache.org/news/2017/11/22/release-1.4-and-1.5-timeline.html. On 29.01.2018 13:41, Christophe Jolif wrote: Thanks a lot. Is there any timeline for 1.5 by the way? -- Christophe On Mon, Jan 29, 2018 at 11:36 AM, Tzu-Li (Gordon)

Re: ElasticsearchSink in Flink 1.4.0 with Elasticsearch 5.2+

2018-01-29 Thread Christophe Jolif
Thanks a lot. Is there any timeline for 1.5 by the way? -- Christophe On Mon, Jan 29, 2018 at 11:36 AM, Tzu-Li (Gordon) Tai wrote: > Hi Christophe, > > Thanks a lot for the contribution! I’ll add reviewing the PR to my backlog. > I would like / will try to take a look at the PR by the end of th

Re: ElasticsearchSink in Flink 1.4.0 with Elasticsearch 5.2+

2018-01-29 Thread Tzu-Li (Gordon) Tai
Hi Christophe, Thanks a lot for the contribution! I’ll add reviewing the PR to my backlog. I would like / will try to take a look at the PR by the end of this week, after some 1.4.1 blockers which I’m still busy with. Cheers, Gordon On 29 January 2018 at 9:25:27 AM, Fabian Hueske (fhue...@gmail

Re: ElasticsearchSink in Flink 1.4.0 with Elasticsearch 5.2+

2018-01-29 Thread Fabian Hueske
Hi Christophe, great! Thanks for your contribution. I'm quite busy right now, but I agree that we should have support for ES 5.3 and Es 6.x for the next minor release 1.5. Best, Fabian 2018-01-26 23:09 GMT+01:00 Christophe Jolif : > Ok, I got it "done". I have a PR for ES5.3 (FLINK-7386) just

Re: ElasticsearchSink in Flink 1.4.0 with Elasticsearch 5.2+

2018-01-26 Thread Christophe Jolif
Ok, I got it "done". I have a PR for ES5.3 (FLINK-7386) just rebasing the original one that was never merged (#4675). And added ES 6.X through RestHighLevelClient on top (FLINK-8101). This is: https://github.com/apache/flink/pull/5374. And believe it or not but someone else submitted a PR for thos

Re: ElasticsearchSink in Flink 1.4.0 with Elasticsearch 5.2+

2018-01-26 Thread Fabian Hueske
Great, thank you! Hopefully, this pushes the PR forward. Thanks, Fabian 2018-01-25 22:30 GMT+01:00 Christophe Jolif : > Hi Fabian, > > FYI I rebased the branch and tested it and it worked OK on a sample. > > -- > Christophe > > On Mon, Jan 22, 2018 at 2:53 PM, Fabian Hueske wrote: > >> Hi Adria

Re: ElasticsearchSink in Flink 1.4.0 with Elasticsearch 5.2+

2018-01-25 Thread Christophe Jolif
Hi Fabian, FYI I rebased the branch and tested it and it worked OK on a sample. -- Christophe On Mon, Jan 22, 2018 at 2:53 PM, Fabian Hueske wrote: > Hi Adrian, > > thanks for raising this issue again. > I agree, we should add support for newer ES versions. > I've added 1.5.0 as target release

Re: ElasticsearchSink in Flink 1.4.0 with Elasticsearch 5.2+

2018-01-22 Thread Adrian Vasiliu
OK, thanks a lot Fabian. Adrian   - Original message -From: Fabian Hueske To: Adrian Vasiliu Cc: user Subject: Re: ElasticsearchSink in Flink 1.4.0 with Elasticsearch 5.2+Date: Mon, Jan 22, 2018 2:54 PM  Hi Adrian, thanks for raising this issue again.I agree, we should add support for

Re: ElasticsearchSink in Flink 1.4.0 with Elasticsearch 5.2+

2018-01-22 Thread Fabian Hueske
Hi Adrian, thanks for raising this issue again. I agree, we should add support for newer ES versions. I've added 1.5.0 as target release for FLINK-7386 and bumped the priority up. In the meantime, you can try Flavio's approach (he responded to the mail thread you linked) and fork and fix the conn