Re: Prometheus Reporter Enhancement

Let's move this to the ticket then. :) On 6/2/2021 8:45 PM, Mason Chen wrote: Hi Chesnay, I would like to take on https://issues.apache.org/jira/browse/FLINK-17495  as a contribution to OSS, if that’s alright with the team. We can discuss im

Re: Prometheus Reporter Enhancement

Hi Chesnay, I would like to take on https://issues.apache.org/jira/browse/FLINK-17495 as a contribution to OSS, if that’s alright with the team. We can discuss implementation details here or in the ticket, but I was thinking about modifying th

Re: Prometheus Reporter Enhancement

There is no plan to generally exclude label keys from the metric identifier/logical scope. They ensure that the label set for a given identifier/scope is unique, i.e., you can't have 2 metrics called "numRecordsIn" with different label sets. Changing this would also break all existing setups, s

Re: Prometheus Reporter Enhancement

Are there any plans to rework some of the metric name formulations (getMetricIdentifier or getLogicalScope)? Currently, the label keys and/or label values are concatenated in the metric name and the information is redundant and makes the metric names longer. Would it make sense to remove the ta

Re: Prometheus Reporter Enhancement

There is already a ticket for this. Note that this functionality should be implemented in a generic fashion to be usable for all reporters. https://issues.apache.org/jira/browse/FLINK-17495 On 5/18/2021 8:16 PM, Andrew Otto wrote: Sounds useful! On Tue, May 18, 2021 at 2:02 PM Mason Chen

Re: Prometheus Reporter Enhancement

Sounds useful! On Tue, May 18, 2021 at 2:02 PM Mason Chen wrote: > Hi all, > > Would people appreciate enhancements to the prometheus reporter to include > extra labels via a configuration, as a contribution to Flink? I can see it > being useful for adding labels that are not job specific, but i

Prometheus Reporter Enhancement

Hi all, Would people appreciate enhancements to the prometheus reporter to include extra labels via a configuration, as a contribution to Flink? I can see it being useful for adding labels that are not job specific, but infra specific. The change would be nicely integrated with the Flink’s Conf