Re: ExecutionConfig.enableTimestamps() in 1.0.0

2016-03-10 Thread Zach Cox
I see the new Event Time docs page, thanks for fixing that! I like the additional explanation of event time and watermarks. I also updated our TimestampExtractors to AssignerWithPeriodicWatermarks as described in [1]. I like the separation between periodic and punctuated watermark assigners in the

Re: ExecutionConfig.enableTimestamps() in 1.0.0

2016-03-10 Thread Ufuk Celebi
Just removed the page. Triggering a new docs build... On Thu, Mar 10, 2016 at 10:22 AM, Aljoscha Krettek wrote: > Then Stephan should have removed the old doc when adding the new one… :-) >> On 10 Mar 2016, at 10:20, Ufuk Celebi wrote: >> >> Just talked with Stephan: the document you are referri

Re: ExecutionConfig.enableTimestamps() in 1.0.0

2016-03-10 Thread Aljoscha Krettek
Then Stephan should have removed the old doc when adding the new one… :-) > On 10 Mar 2016, at 10:20, Ufuk Celebi wrote: > > Just talked with Stephan: the document you are referring to is stale. > Can you check out this one here: > https://ci.apache.org/projects/flink/flink-docs-release-1.0/apis/

Re: ExecutionConfig.enableTimestamps() in 1.0.0

2016-03-10 Thread Ufuk Celebi
Just talked with Stephan: the document you are referring to is stale. Can you check out this one here: https://ci.apache.org/projects/flink/flink-docs-release-1.0/apis/streaming/event_time.html – Ufuk On Thu, Mar 10, 2016 at 10:17 AM, Ufuk Celebi wrote: > I've added this to the migration guide

Re: ExecutionConfig.enableTimestamps() in 1.0.0

2016-03-10 Thread Ufuk Celebi
I've added this to the migration guide here: https://cwiki.apache.org/confluence/display/FLINK/Migration+Guide%3A+0.10.x+to+1.0.x Feel free to add any other API changes that are missing there. – Ufuk On Thu, Mar 10, 2016 at 10:13 AM, Aljoscha Krettek wrote: > Hi, > you’re right, this should be

Re: ExecutionConfig.enableTimestamps() in 1.0.0

2016-03-10 Thread Aljoscha Krettek
Hi, you’re right, this should be changed to “setStreamTimeCharacteristic(EventTime)” in the doc. Cheers, Aljoscha > On 09 Mar 2016, at 23:21, Zach Cox wrote: > > Hi - I'm upgrading our app to 1.0.0 and noticed ExecutionConfig no longer has > an enableTimestamps() method. Do we just not need t

ExecutionConfig.enableTimestamps() in 1.0.0

2016-03-09 Thread Zach Cox
Hi - I'm upgrading our app to 1.0.0 and noticed ExecutionConfig no longer has an enableTimestamps() method. Do we just not need to call that at all now? The docs still say to call it [1] - do they just need to be updated? Thanks, Zach [1] https://ci.apache.org/projects/flink/flink-docs-release-1