Re: Dead code in ES Sink

2021-01-14 Thread Aljoscha Krettek
On 2021/01/13 07:50, Rex Fenley wrote: Are you saying that this option does get passed along to Elasticsearch still or that it's just arbitrarily validated? According to [1] it's been deprecated in ES 6 and removed in ES 7. [1] https://github.com/elastic/elasticsearch/pull/38085 Sorry, I wasn'

Re: Dead code in ES Sink

2021-01-13 Thread Rex Fenley
>The actual field is never used but it will be used to check the allowed options when verifying what users specify via "string" options. Are you saying that this option does get passed along to Elasticsearch still or that it's just arbitrarily validated? According to [1] it's been deprecated in ES

Re: Dead code in ES Sink

2021-01-13 Thread Aljoscha Krettek
On 2021/01/12 15:04, Rex Fenley wrote: [2] https://github.com/apache/flink/blob/97bfd049951f8d52a2e0aed14265074c4255ead0/flink-connectors/flink-connector-elasticsearch-base/src/main/java/org/apache/flink/streaming/connectors/elasticsearch/table/ElasticsearchOptions.java#L131 Should [2] be remove

Dead code in ES Sink

2021-01-12 Thread Rex Fenley
Hi, I was looking through ES options trying to diagnose a SocketTimeOut we're receiving on the ES TableAPI connector. A bug report on elasticsearch's github[1] indicated I might want to set max retry timeout really high, but from what I can tell it's not even consumed anywhere [2]. [1] https://gi