Re: DataStreamUtils and Scala

2016-02-02 Thread Márton Balassi
Opened the PR. [1] Will merge the re-add "getJavaStream()" method commit as soon as travis passes if no objections, the second approach can be discussed on github. [1] https://github.com/apache/flink/pull/1574 Best, Marton On Mon, Feb 1, 2016 at 10:56 PM, Márton Balassi wrote: > I'll do the

Re: DataStreamUtils and Scala

2016-02-01 Thread Márton Balassi
I'll do the fix(es) tomorrow morning. Best, Marton On Mon, Feb 1, 2016, 20:05 Cory Monty wrote: > Thanks for the quick response! > > Either solution works for us. > > On Mon, Feb 1, 2016 at 12:07 PM, Stephan Ewen wrote: > >> I would actually re-add the "getJavaStream()" method. There are prob

Re: DataStreamUtils and Scala

2016-02-01 Thread Cory Monty
Thanks for the quick response! Either solution works for us. On Mon, Feb 1, 2016 at 12:07 PM, Stephan Ewen wrote: > I would actually re-add the "getJavaStream()" method. There are probably > other cases when people need it, and it does not hurt to expose it. > > Also, it allows you to combine p

Re: DataStreamUtils and Scala

2016-02-01 Thread Stephan Ewen
I would actually re-add the "getJavaStream()" method. There are probably other cases when people need it, and it does not hurt to expose it. Also, it allows you to combine programs written partly against the Java and Scala API (if you would ever want to do that). Stephan On Mon, Feb 1, 2016 at

DataStreamUtils and Scala

2016-02-01 Thread Cory Monty
Hey there, We were using DataStreamUtils.collect in Scala for automated testing, which only works because of `DataStream.getJavaStream` accessor in the Scala version of `DataStream`. However, a recent commit ( https://github.com/apache/flink/commit/086acf681f01f2da530c04289e0682c56f98a378) removed

Re: DataStreamUtils and Scala

2016-02-01 Thread Márton Balassi
Hey Cory, Sorry, I did not mean to break your code. One solution that I could suggest is to do it the way we have it for the batch api, namely having a scala version for DataStreamUtils too. It might be placed under flink-contrib for the time being. Would that solution fit your needs? On Mon, Fe