RE: Re: Inconsistent data format of flink-training-repo and learn-flink doc

2023-02-24 Thread Zhongpu Chen
ues > > Best regards, > Yuxia > > > 发件人: "Zhongpu Chen" > 收件人: "User" > 发送时间: 星期二, 2023年 2 月 21日 下午 8:49:13 > 主题: Inconsistent data format of flink-training-repo and learn-flink doc > > Hi, > The data format specified in flink-training-r

RE: Re: Re: Should we always mark ValueState as "transient" for RichFunctions

2023-02-24 Thread Zhongpu Chen
only be deserialized when the job is submitted, do you want > to test the impact of this on submission throughput? > > Best, > Shammon > > > On Fri, Feb 24, 2023 at 3:04 PM Zhongpu Chen wrote: > > > Hi Gen, > > > > Thanks for your explanation. > &g

RE: Re: Should we always mark ValueState as "transient" for RichFunctions

2023-02-23 Thread Zhongpu Chen
alueState itself is not a Serializable. It should be > ok to always mark it as transient. > > In this case, I suppose it works because the ValueState is not set (which > happens during the runtime) when the function is serialized (while > deploying). But it's not good. >

Should we always mark ValueState as "transient" for RichFunctions

2023-02-23 Thread Zhongpu Chen
Hi, When I am reading the code from flink-training-repo [1], I noticed the following code: ```java public static class EnrichmentFunction extends RichCoFlatMapFunction { private ValueStaterideState; private ValueStatefareState; ... } ``` From my understanding, since ValueState

RE: Re: Inconsistent data format of flink-training-repo and learn-flink doc

2023-02-21 Thread Zhongpu Chen
e help create a JIRA[2] for it? And if you're interested to fix it, weclome to contribute. > > [1] https://github.com/apache/flink-training/pull/36 > [2] https://issues.apache.org/jira/projects/FLINK/issues > > Best regards, > Yuxia > > > 发件人: "Zhongpu Chen"

Inconsistent data format of flink-training-repo and learn-flink doc

2023-02-21 Thread Zhongpu Chen
k-docs-release-1.16/docs/learn-flink/etl/) tried to get both "startTime" and "endTime". But in fact, those are not defined in flink-training-repo. ```java Interval rideInterval = new Interval(ride.startTime, ride.endTime); ``` I think such inconsistency would puzzle new comers of Flink. -- Zhongpu Chen