Re: Row slice / cache performance

2010-05-03 Thread Jonathan Ellis
On Sun, May 2, 2010 at 1:00 PM, James Golick wrote: > the ConcurrentSkipListMap (ColumnFamily.columns_). > SliceQueryFilter.getMemColumnIterator @ ~30% - Virtually all the time in > here is spent in ConcurrentSkipListMap$Values.toArrray() Besides the UUID optimization you posted, we should do an

Re: Row slice / cache performance

2010-05-02 Thread James Golick
Got a ~50% improvement by making UUID comparison less heavy-weight. https://issues.apache.org/jira/browse/CASSANDRA-1043 On Sun, May 2, 2010 at 7:49 PM, James Golick wrote: > Just an update on this. I wrote a patch which attempts to solve this > problem by keeping an index of columns that are m

Re: Row slice / cache performance

2010-05-02 Thread James Golick
Just an update on this. I wrote a patch which attempts to solve this problem by keeping an index of columns that are marked for deletion to avoid having to iterate over the whole column set and call columns_.get() over and over again. My patch works, and the time spent in removeDeleted() is now cl

Re: Row slice / cache performance

2010-05-02 Thread James Golick
Not sure why the first paragraph turned in to a numbered bullet... On Sun, May 2, 2010 at 11:00 AM, James Golick wrote: > >1. I wrote the list a while back about less-than-great performance when >reading thousands of columns even on cache hits. Last night, I decided to >try to get to