Re: [Request for Feedback] Swift SDK Prototype

2023-09-20 Thread Byron Ellis via user
Hi all, I've chatted with a couple of people offline about this and my impression is that folks are generally amenable to a separate repo to match the target community? I have no idea what the next steps would be though other than guessing that there's probably some sort of PMC thing involved? Sho

Re: [Request for Feedback] Swift SDK Prototype

2023-09-20 Thread Chamikara Jayalath via user
On Wed, Sep 20, 2023 at 9:54 AM Byron Ellis wrote: > Hi all, > > I've chatted with a couple of people offline about this and my impression > is that folks are generally amenable to a separate repo to match the target > community? I have no idea what the next steps would be though other than > gue

Re: [Request for Feedback] Swift SDK Prototype

2023-09-20 Thread Byron Ellis via user
Sure, we could definitely include things as a submodule for stuff like testing multi-language, though I think there's actually a cleaner way just using the Swift package manager's test facilities to access the swift sdk repo. That would also be consistent with the user-side experience and let us

Re: [Request for Feedback] Swift SDK Prototype

2023-09-20 Thread Danny McCormick via user
> I think the process should be similar to other code/design reviews for large contributions. I don't think you need a PMC involvement here. I think it does require PMC involvement to create the actual repo once we have public consensus. I tried the flow at https://infra.apache.org/version-control

Re: [Request for Feedback] Swift SDK Prototype

2023-09-20 Thread Chamikara Jayalath via user
On Wed, Sep 20, 2023 at 10:48 AM Danny McCormick wrote: > > I think the process should be similar to other code/design reviews for > large contributions. I don't think you need a PMC involvement here. > > I think it does require PMC involvement to create the actual repo once we > have public cons

Re: [Request for Feedback] Swift SDK Prototype

2023-09-20 Thread Byron Ellis via user
I actually don't think we'll need any of the multi-repo github actions, Swift packages are basically 1:1 with repos so the build process will actually do all the checkouts. What we'd do is put a test package in the sdks/swift, which works fine since it doesn't ever get used as a dependency that dep