Re: Gigantic list of Avro spec issues

2022-02-17 Thread Martin Grigorov
On Fri, Feb 18, 2022 at 5:00 AM Askar Safin wrote: > > By the way, we have what we believe to be the most correct and complete > Rust > > implementation of Avro here: > > https://github.com/MaterializeInc/materialize/tree/main/src/avro > Hi. I spent a lot of time searching for perfect Avro implem

Re: Gigantic list of Avro spec issues

2022-02-17 Thread Brennan Vincent
Yes, I 100% agree. I would like to do a side project eventually of improving avro_derive in the way you suggest (or replacing it with Serde). I just haven't gotten around to doing so. But what we have is working for Materialize for now. > On Feb 17, 2022, at 10:00 PM, Askar Safin wrote: > > >

Re: Gigantic list of Avro spec issues

2022-02-17 Thread Askar Safin
> By the way, we have what we believe to be the most correct and complete Rust > implementation of Avro here: >   https://github.com/MaterializeInc/materialize/tree/main/src/avro Hi. I spent a lot of time searching for perfect Avro implementation for Rust. And indeed Materialize implementation tu

Re: Gigantic list of Avro spec issues

2022-02-17 Thread Brennan Vincent
(To clarify: we have NOT licensed that entire Materialize repo under Apache v2.0. I am only referring to the `avro` and `avro-derive` crates). > On Feb 17, 2022, at 1:11 PM, Brennan Vincent wrote: > > By the way, we have what we believe to be the most correct and complete Rust > implementation

Re: Gigantic list of Avro spec issues

2022-02-17 Thread Brennan Vincent
By the way, we have what we believe to be the most correct and complete Rust implementation of Avro here: https://github.com/MaterializeInc/materialize/tree/main/src/avro You are welcome to use it (and the related `avro_derive` c

Re: Gigantic list of Avro spec issues

2022-02-17 Thread Brennan Vincent
Hello, Why was I included in the To: field of this e-mail; do you have a question/comment for me specifically? > On Feb 17, 2022, at 10:47 AM, Askar Safin wrote: > > Hi. > > To all: it seems my language was too strong. I'm sorry about this. But I still > don't plan to fill separate bug report

Re: Gigantic list of Avro spec issues

2022-02-17 Thread Askar Safin
Hi. To all: it seems my language was too strong. I'm sorry about this. But I still don't plan to fill separate bug reports or pull requests. To Dan Schmitt: Воскресенье, 13 февраля 2022, 3:55 +03:00 от "Dan Schmitt" < dan.schm...@gmail.com >: > * [Opinion] [Line 737]. "The 16-byte, randomly-gen

Re: Gigantic list of Avro spec issues

2022-02-14 Thread Ryan Skraba
Hello! Thanks, Dan, for your calm and measured response -- you've given some excellent advice on how someone can make a positive contribution to the project and the spec. Askar, your approach in presenting your specification review should have been more constructive: it isn't useful to cross-post

Re: Gigantic list of Avro spec issues

2022-02-13 Thread Dan Schmitt
I will admit the spec is likely weak around unicode/utf encoding, (as the serialization of strings to json isn't consistent across all language bindings) but I file the ticket against implementations and write test cases rather than make guesses at the spec wording and make demands without knowing

Re: Gigantic list of Avro spec issues

2022-02-12 Thread Dan Schmitt
Generally the "I'm going to lump all my complaints into one big bug" is a good way to get them ignored. I'll skip "the design is wrong and it should change because I don't like it" and cite "it's used everywhere with lots of implementations so you can't change it in an incompatible way". I'll ski

Gigantic list of Avro spec issues

2022-02-12 Thread Askar Safin
Hi. I'm writing my own Avro implementation in Rust for personal use. During this work I found a lot of issues in Avro spec (the list follows). I send this mail not only to user and dev mailing lists of Avro, but also to Apache community list, Kafka list and 3 semi-randomly chosen Materialize e