Stefano Verzegnassi has proposed merging
lp:~verzegnassi-stefano/ubuntu-docviewer-app/content-hub-dont-load-async into
lp:ubuntu-docviewer-app.
Commit message:
Do not initialize content-hub asynchronously, otherwise a transfer can not be
finalized if the app is not already launched.
This bug
That happens also with the release currently available on the store (i.e. does
not depend on this MP). If docviewer is already launched, everything works as
expected.
In the log is there anything about Libertine containers? I started to see this
problem when content-hub has added the support fo
I hope managers will decide to fix these problems with unmaintained projects.
For now, let's suppose there has been a tacit approval.
--
https://code.launchpad.net/~verzegnassi-stefano/ubuntu-terminal-app/device-detection/+merge/287985
Your team Ubuntu Terminal Developers is requested to review t
The proposal to merge
lp:~verzegnassi-stefano/ubuntu-terminal-app/device-detection into
lp:ubuntu-terminal-app has been updated.
Status: Needs review => Approved
For more details, see:
https://code.launchpad.net/~verzegnassi-stefano/ubuntu-terminal-app/device-detection/+merge/287985
--
You
The proposal to merge lp:~verzegnassi-stefano/ubuntu-terminal-app/fix-1488588
into lp:ubuntu-terminal-app has been updated.
Status: Needs review => Approved
For more details, see:
https://code.launchpad.net/~verzegnassi-stefano/ubuntu-terminal-app/fix-1488588/+merge/290031
--
Your team Ubun
The proposal to merge
lp:~verzegnassi-stefano/ubuntu-terminal-app/uitk13-deprecation into
lp:ubuntu-terminal-app has been updated.
Status: Needs review => Approved
For more details, see:
https://code.launchpad.net/~verzegnassi-stefano/ubuntu-terminal-app/uitk13-deprecation/+merge/287990
--
The proposal to merge lp:~verzegnassi-stefano/ubuntu-terminal-app/fix-1559892
into lp:ubuntu-terminal-app has been updated.
Status: Needs review => Approved
For more details, see:
https://code.launchpad.net/~verzegnassi-stefano/ubuntu-terminal-app/fix-1559892/+merge/290129
--
Your team Ubun
The proposal to merge
lp:~verzegnassi-stefano/ubuntu-docviewer-app/fix-documents-page-keyboard into
lp:ubuntu-docviewer-app has been updated.
Status: Needs review => Approved
For more details, see:
https://code.launchpad.net/~verzegnassi-stefano/ubuntu-docviewer-app/fix-documents-page-keybo
I will mind to open a bug at ubuntu-ui-toolkit. I'm really missing the old
PageHeadState behaviour too... :/
Thanks again for the review!
--
https://code.launchpad.net/~verzegnassi-stefano/ubuntu-docviewer-app/fix-documents-page-keyboard/+merge/291139
Your team Ubuntu Document Viewer Developers i
The proposal to merge lp:~verzegnassi-stefano/ubuntu-docviewer-app/fix-1566903
into lp:ubuntu-docviewer-app has been updated.
Status: Needs review => Approved
For more details, see:
https://code.launchpad.net/~verzegnassi-stefano/ubuntu-docviewer-app/fix-1566903/+merge/291142
--
Your team U
The proposal to merge lp:~verzegnassi-stefano/ubuntu-docviewer-app/fix-1566903
into lp:ubuntu-docviewer-app has been updated.
Status: Needs review => Approved
For more details, see:
https://code.launchpad.net/~verzegnassi-stefano/ubuntu-docviewer-app/fix-1566903/+merge/291142
--
Your team U
Stefano Verzegnassi has proposed merging
lp:~verzegnassi-stefano/ubuntu-docviewer-app/content-hub-imported-folder into
lp:ubuntu-docviewer-app.
Commit message:
Save imported files from content-hub in a separate folder.
Requested reviews:
Ubuntu Document Viewer Developers (ubuntu-docviewer
UITK docs are not very clear on what to do when a Page have multiple
PageHeaders.
I used the clock-app code (more specifically, the alarm page) as reference,
since you already completed the migration to UC 1.3 at the time.
I'm not sure about the use of QML Loaders, since it would look a bit "dir
Stefano Verzegnassi has proposed merging
lp:~verzegnassi-stefano/ubuntu-docviewer-app/fix-1545142 into
lp:ubuntu-docviewer-app.
Commit message:
PdfViewer - Presentation mode: use a single-tap gesture (instead of double tap)
to show/hide header
Requested reviews:
Ubuntu Document Viewer
Review: Approve
LGTM, thanks!
--
https://code.launchpad.net/~popey/ubuntu-filemanager-app/fix-1554621/+merge/291133
Your team Ubuntu File Manager Developers is requested to review the proposed
merge of lp:~popey/ubuntu-filemanager-app/fix-1554621 into
lp:ubuntu-filemanager-app.
--
Mailing lis
Review: Needs Fixing
As to the colors, everything is okay except for a typo (see the diff comment).
Sidebar color is not set and it's shown as white, when "#f7f7f7" (porcelain)
should be used instead.
Diff comments:
>
> === modified file 'src/app/qml/components/PlacesSidebar.qml'
> --- src/ap
Also, update the AppArmor policy version to "1.3", otherwise the app cannot be
launched in a confined environment.
--
https://code.launchpad.net/~popey/ubuntu-filemanager-app/fix-1554621/+merge/291133
Your team Ubuntu File Manager Developers is requested to review the proposed
merge of lp:~popey
Review: Needs Fixing
I still have to have a better look at the app color palette, anyway there's
surely something which needs to be fixed:
$ grep -r "ubuntu-sdk" .
./manifest.json.in:"framework": "ubuntu-sdk-14.10",
The app is still using an old framework version.
Please update it to "ubun
Stefano Verzegnassi has proposed merging
lp:~verzegnassi-stefano/ubuntu-docviewer-app/fix-1566903 into
lp:ubuntu-docviewer-app.
Commit message:
Fixed wrong alignment of the peer picker in SharePage.
Requested reviews:
Ubuntu Document Viewer Developers (ubuntu-docviewer-dev)
Related bugs
Stefano Verzegnassi has proposed merging
lp:~verzegnassi-stefano/ubuntu-docviewer-app/fix-documents-page-keyboard into
lp:ubuntu-docviewer-app.
Commit message:
Fixed the keyboard input issues in DocumentsPage, caused by the migration to
the new PageHeader component. In particular:
* OSK
The proposal to merge
lp:~verzegnassi-stefano/ubuntu-docviewer-app/release-2.1.2 into
lp:ubuntu-docviewer-app has been updated.
Status: Needs review => Approved
For more details, see:
https://code.launchpad.net/~verzegnassi-stefano/ubuntu-docviewer-app/release-2.1.2/+merge/290962
--
Your t
The proposal to merge
lp:~verzegnassi-stefano/ubuntu-terminal-app/device-detection into
lp:ubuntu-terminal-app has been updated.
Description changed to:
*** REQUIRES OTA-10 ***
Added a context property which allows terminal-app to know whether a keyboard
or a mouse is attached to the device.
Stefano Verzegnassi has proposed merging
lp:~verzegnassi-stefano/ubuntu-docviewer-app/release-2.1.2 into
lp:ubuntu-docviewer-app.
Commit message:
* Bumped framework to 15.04.4
* Fixed broken night mode (i.e. app background is still white when the mode is
enabled)
* Updated changelog
Requested
The proposal to merge
lp:~verzegnassi-stefano/ubuntu-docviewer-app/uitk13-documents-page into
lp:ubuntu-docviewer-app has been updated.
Status: Needs review => Approved
For more details, see:
https://code.launchpad.net/~verzegnassi-stefano/ubuntu-docviewer-app/uitk13-documents-page/+merge/2
> Haha, are you enjoyed deleting this code? ;)
Ahah, you can be sure of it! :)
> Why did you switch it [PageHeader.flickable] off? Just for information.
I was having trouble in setting the anchors for the content of the
ViewerPage[1], and the LibreOffice Viewer had strange bindings that were
cau
> Should you extract this component to separate file since it is declared twice?
Done! (also, TextualButtonWithIcon has been merged into TextualButton)
> Overall feeling - so much logic is located in headers.
> I know that you only rewriting some staff to UITK 1.3, just wanted to note
> that.
>
> Should you remove FIXME? Is it wrapping itself now?
Yes, it wraps the text by default (it's limited to maximum one line of text
though).
I kept the comment because we may want to reserve two lines for the document
name in future, however the visual result is not so good (i.e. text is - of
cou
The proposal to merge
lp:~verzegnassi-stefano/ubuntu-docviewer-app/uitk13-pdfview into
lp:ubuntu-docviewer-app has been updated.
Status: Needs review => Approved
For more details, see:
https://code.launchpad.net/~verzegnassi-stefano/ubuntu-docviewer-app/uitk13-pdfview/+merge/290172
--
Your
The proposal to merge
lp:~verzegnassi-stefano/ubuntu-docviewer-app/uitk13-textview into
lp:ubuntu-docviewer-app has been updated.
Status: Needs review => Approved
For more details, see:
https://code.launchpad.net/~verzegnassi-stefano/ubuntu-docviewer-app/uitk13-textview/+merge/289482
--
Yo
Yes, I'm moving all the pages to the new approach (there are already a few MPs
for them).
Thanks for the review!
--
https://code.launchpad.net/~verzegnassi-stefano/ubuntu-docviewer-app/uitk13-textview/+merge/289482
Your team Ubuntu Document Viewer Developers is subscribed to branch
lp:ubuntu-do
Stefano Verzegnassi has proposed merging
lp:~verzegnassi-stefano/ubuntu-docviewer-app/uitk13-pdfview into
lp:ubuntu-docviewer-app with
lp:~verzegnassi-stefano/ubuntu-docviewer-app/uitk-theming-silo-50 as a
prerequisite.
Commit message:
Pdf viewer:
* Removed 'search' action (unuse
Stefano Verzegnassi has proposed merging
lp:~verzegnassi-stefano/ubuntu-docviewer-app/uitk13-documents-page into
lp:ubuntu-docviewer-app.
Commit message:
* Use PageHeader and ScrollView in documents page
* Removed width limitation of units.gu(80) from documents page
* Code refactoring
* Use
Hey Roman, I can think at three alternatives:
1) Set MainView.backgroundColor according to the nightMode status.
MainView {
backgroundColor: nightModeEnabled ? "black" : "white"
}
I'm almost sure you'll also have to disable auto-theming (i.e. UITK
switches the app theme between Ambiance and
Stefano Verzegnassi has proposed merging
lp:~verzegnassi-stefano/ubuntu-terminal-app/fix-1559892 into
lp:ubuntu-terminal-app.
Commit message:
Added missing 'NotifyDialog.qml' file, so that app can properly notify whether
a wrong password has been typed during PAM auth
Request
** Changed in: ubuntu-terminal-app
Status: Fix Committed => Fix Released
--
You received this bug notification because you are a member of Ubuntu
File Manager Developers, which is subscribed to Ubuntu File Manager App.
Matching subscriptions: File Manager App Bugmail, Ubuntu RSS Reader Bug
** Changed in: ubuntu-terminal-app
Status: Fix Committed => Fix Released
--
You received this bug notification because you are a member of Ubuntu
File Manager Developers, which is subscribed to Ubuntu File Manager App.
Matching subscriptions: File Manager App Bugmail
https://bugs.launchpad
MainView now sets the background of the main window, instead of using a QML
Rectangle.
Since the BG is not a child item of MainView anymore, the "night mode" shader
can't alter the color.
Refs.
- https://bugs.launchpad.net/ubuntu/+source/ubuntu-ui-toolkit/+bug/1439133
- https://code.launchpad.ne
Stefano Verzegnassi has proposed merging
lp:~verzegnassi-stefano/ubuntu-docviewer-app/uitk13-lok-page into
lp:ubuntu-docviewer-app.
Commit message:
* WORKAROUND: make the lok-viewer header static (avoid unpredictable binding)
* Use new PageHeader and ScrollView components
* UI: Show an empty
Stefano Verzegnassi has proposed merging
lp:~verzegnassi-stefano/ubuntu-terminal-app/fix-1488588 into
lp:ubuntu-terminal-app.
Commit message:
* Expose drag mode settings to QML
* Disabled drag support in ubuntu-terminal-app in order to workaround the
missing support in Mir
Requested reviews
Review: Approve
Looks good to me!
By the way, I just want to take the opportunity to thank you for the time
you've spent on the core apps. Good luck with juju! :)
--
https://code.launchpad.net/~nskaggs/ubuntu-docviewer-app/restore-ap-template/+merge/288454
Your team Ubuntu Document Viewer Develo
Stefano Verzegnassi has proposed merging
lp:~verzegnassi-stefano/ubuntu-docviewer-app/uitk13-textview into
lp:ubuntu-docviewer-app.
Commit message:
[TextView] Switch to UITK 1.3 PageHeader component
Requested reviews:
Ubuntu Document Viewer Developers (ubuntu-docviewer-dev)
For more details
The proposal to merge
lp:~verzegnassi-stefano/ubuntu-docviewer-app/uitk13-details-page into
lp:ubuntu-docviewer-app has been updated.
Status: Needs review => Approved
For more details, see:
https://code.launchpad.net/~verzegnassi-stefano/ubuntu-docviewer-app/uitk13-details-page/+merge/28855
The proposal to merge lp:~verzegnassi-stefano/ubuntu-docviewer-app/fix-1483218
into lp:ubuntu-docviewer-app has been updated.
Status: Needs review => Approved
For more details, see:
https://code.launchpad.net/~verzegnassi-stefano/ubuntu-docviewer-app/fix-1483218/+merge/288689
--
Your team U
The proposal to merge lp:~nskaggs/ubuntu-docviewer-app/restore-ap-template into
lp:ubuntu-docviewer-app has been updated.
Status: Needs review => Approved
For more details, see:
https://code.launchpad.net/~nskaggs/ubuntu-docviewer-app/restore-ap-template/+merge/288454
--
Your team Ubuntu Do
The proposal to merge lp:~nskaggs/ubuntu-docviewer-app/create-cache into
lp:ubuntu-docviewer-app has been updated.
Status: Needs review => Approved
For more details, see:
https://code.launchpad.net/~nskaggs/ubuntu-docviewer-app/create-cache/+merge/288718
--
Your team Ubuntu Document Viewer
The proposal to merge lp:~nskaggs/ubuntu-docviewer-app/create-cache into
lp:ubuntu-docviewer-app has been updated.
Status: Needs review => Approved
For more details, see:
https://code.launchpad.net/~nskaggs/ubuntu-docviewer-app/create-cache/+merge/288718
--
Your team Ubuntu Document Viewer
The proposal to merge lp:~nskaggs/ubuntu-docviewer-app/create-cache into
lp:ubuntu-docviewer-app has been updated.
Status: Approved => Needs review
For more details, see:
https://code.launchpad.net/~nskaggs/ubuntu-docviewer-app/create-cache/+merge/288718
--
Your team Ubuntu Document Viewer
The proposal to merge lp:~nskaggs/ubuntu-docviewer-app/create-cache into
lp:ubuntu-docviewer-app has been updated.
Status: Approved => Needs review
For more details, see:
https://code.launchpad.net/~nskaggs/ubuntu-docviewer-app/create-cache/+merge/288718
--
Your team Ubuntu Document Viewer
The proposal to merge lp:~nskaggs/ubuntu-docviewer-app/create-cache into
lp:ubuntu-docviewer-app has been updated.
Status: Needs review => Approved
For more details, see:
https://code.launchpad.net/~nskaggs/ubuntu-docviewer-app/create-cache/+merge/288718
--
Your team Ubuntu Document Viewer
Review: Approve
--
https://code.launchpad.net/~nskaggs/ubuntu-docviewer-app/create-cache/+merge/288718
Your team Ubuntu Document Viewer Developers is subscribed to branch
lp:ubuntu-docviewer-app.
--
Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers
Post to : ubuntu-touc
Stefano Verzegnassi has proposed merging
lp:~verzegnassi-stefano/ubuntu-terminal-app/uitk13-deprecation into
lp:ubuntu-terminal-app.
Commit message:
* Use UITK PageHeader, instead of the now deprecated "Page.head" property
* Use ScrollView where appropriate
* Use UITK Label, inst
Stefano Verzegnassi has proposed merging
lp:~verzegnassi-stefano/ubuntu-terminal-app/device-detection into
lp:ubuntu-terminal-app.
Commit message:
Added a context property which allows terminal-app to know whether a keyboard
or a mouse is attached to the device.
This is required to workaround
Stefano Verzegnassi has proposed merging
lp:~verzegnassi-stefano/ubuntu-docviewer-app/test into lp:ubuntu-docviewer-app.
Commit message:
test
Requested reviews:
Ubuntu Document Viewer Developers (ubuntu-docviewer-dev)
For more details, see:
https://code.launchpad.net/~verzegnassi-stefano
Stefano Verzegnassi has proposed merging
lp:~verzegnassi-stefano/ubuntu-docviewer-app/fix-1483218 into
lp:ubuntu-docviewer-app.
Commit message:
emit DocumentModel::dataChanged()
Sometimes the UI was not notified about changes in model entries (e.g. file
size still equals to zero after file has
Stefano Verzegnassi has proposed merging
lp:~verzegnassi-stefano/ubuntu-docviewer-app/minor-code-styling into
lp:ubuntu-docviewer-app.
Commit message:
Minor code style changes
Requested reviews:
Ubuntu Document Viewer Developers (ubuntu-docviewer-dev)
For more details, see:
https
Stefano Verzegnassi has proposed merging
lp:~verzegnassi-stefano/ubuntu-docviewer-app/uitk13-details-page into
lp:ubuntu-docviewer-app.
Commit message:
Use PageHeader and ScrollView in details page
Requested reviews:
Ubuntu Document Viewer Developers (ubuntu-docviewer-dev)
For more details
Stefano Verzegnassi has proposed merging
lp:~verzegnassi-stefano/ubuntu-docviewer-app/uitk-theming-silo-50 into
lp:ubuntu-docviewer-app.
Commit message:
* Updated copyright
* Removed usage of deprecated colors (e.g. UbuntuColors.midAubergine)
* Align to the latest clock-app specs (i.e. don&#
The proposal to merge lp:~nskaggs/ubuntu-terminal-app/restore-autopilot into
lp:ubuntu-terminal-app has been updated.
Status: Needs review => Approved
For more details, see:
https://code.launchpad.net/~nskaggs/ubuntu-terminal-app/restore-autopilot/+merge/288347
--
Your team Ubuntu Terminal
Review: Approve
Ok, thanks! LGTM
--
https://code.launchpad.net/~nskaggs/ubuntu-terminal-app/restore-autopilot/+merge/288347
Your team Ubuntu Terminal Developers is subscribed to branch
lp:ubuntu-terminal-app.
--
Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers
Post to :
Review: Needs Information
Tested on my PC and it works well.
My only question is about Python coding style: should we still refer to the
pep8 conventions?
PS. One diff comment included (i.e. music-app typo).
==
$ pep8 ./tests
./tests/autopilot/ubuntu_terminal_app/tests/__init__.py:42:80:
The proposal to merge
lp:~verzegnassi-stefano/ubuntu-terminal-app/hide-terminal-data-on-auth into
lp:ubuntu-terminal-app has been updated.
Status: Needs review => Approved
For more details, see:
https://code.launchpad.net/~verzegnassi-stefano/ubuntu-terminal-app/hide-terminal-data-on-auth/+
Review: Approve
I guess you decided to set the values from the 'Component.onCompleted' event in
order to prevent the window size from being updated after a change of the font
size.
That's okay to me, it's the Konsole behaviour we discussed earlier.
Looks good to me! Thanks Evan!
--
https:
The proposal to merge lp:~mcintire-evan/ubuntu-terminal-app/window-font-size
into lp:ubuntu-terminal-app has been updated.
Status: Needs review => Approved
For more details, see:
https://code.launchpad.net/~mcintire-evan/ubuntu-terminal-app/window-font-size/+merge/285285
--
Your team Ubuntu
The proposal to merge lp:~nskaggs/ubuntu-terminal-app/add-jenkins-info into
lp:ubuntu-terminal-app has been updated.
Status: Needs review => Approved
For more details, see:
https://code.launchpad.net/~nskaggs/ubuntu-terminal-app/add-jenkins-info/+merge/288165
--
Your team Ubuntu Terminal De
Review: Approve
--
https://code.launchpad.net/~nskaggs/ubuntu-terminal-app/add-jenkins-info/+merge/288165
Your team Ubuntu Terminal Developers is subscribed to branch
lp:ubuntu-terminal-app.
--
Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers
Post to : ubuntu-touch-cor
Stefano Verzegnassi has proposed merging
lp:~verzegnassi-stefano/ubuntu-terminal-app/hide-terminal-data-on-auth into
lp:ubuntu-terminal-app.
Commit message:
Hide terminal data until the access is granted (using a FastBlur).
Requested reviews:
Ubuntu Terminal Developers (ubuntu-terminal-dev
Huh, mark the comment about the 2px value as WORKAROUND, in case we'll decide
in a distant future to move from the current code to a more "QML-friendly"
implementation.
--
https://code.launchpad.net/~mcintire-evan/ubuntu-terminal-app/window-font-size/+merge/285285
Your team Ubuntu Terminal Devel
And here we go! I've found the reason of such strange behaviour!
Diff comments:
>
> === modified file 'src/app/qml/ubuntu-terminal-app.qml'
> --- src/app/qml/ubuntu-terminal-app.qml 2016-02-07 18:24:56 +
> +++ src/app/qml/ubuntu-terminal-app.qml 2016-02-13 21:25:20 +
> @@ -12
I replied to your question. :)
Diff comments:
> === modified file 'src/app/main.cpp'
> --- src/app/main.cpp 2016-01-25 12:37:14 +
> +++ src/app/main.cpp 2016-02-13 21:25:20 +
> @@ -53,7 +53,7 @@
> {
> QApplication a(argc, argv);
> QQuickView view;
> -view.setResizeMode(QQ
Review: Needs Fixing
Overall it looks okay to me. Thanks for this merge proposal! :)
I left 5 diff comments + two further notes (here below):
1) In "README.md":
- I like the idea of providing some information about the application plugins.
However, I'd prefer to provide some more general infor
The proposal to merge
lp:~verzegnassi-stefano/ubuntu-docviewer-app/frieza-lok-zoom-selector into
lp:ubuntu-docviewer-app has been updated.
Status: Needs review => Approved
For more details, see:
https://code.launchpad.net/~verzegnassi-stefano/ubuntu-docviewer-app/frieza-lok-zoom-selector/+m
Stefano Verzegnassi has proposed merging
lp:~verzegnassi-stefano/ubuntu-docviewer-app/frieza-lok-zoom-selector into
lp:ubuntu-docviewer-app.
Commit message:
[lok-viewer] Fixed ZoomSelector visibility on frieza (BQ M10)
Requested reviews:
Ubuntu Document Viewer Developers (ubuntu-docviewer
@Alan, any progress on this? Does it make sense to change the ownership of this
branch, so that the team can finish the QML implementation?
--
https://code.launchpad.net/~popey/ubuntu-terminal-app/add-control/+merge/282280
Your team Ubuntu Terminal Developers is subscribed to branch
lp:ubuntu-te
Hi Evan,
No problem, I've been busy with my exams too. :)
I've planned to spend some time on terminal-app tomorrow. Feel free to ping
whenever you want on IRC/mail/mailing list/telegram if you need to ask
something.
--
https://code.launchpad.net/~mcintire-evan/ubuntu-terminal-app/window-font-si
Stefano Verzegnassi has proposed merging
lp:~verzegnassi-stefano/ubuntu-docviewer-app/cmake-click-cache-option into
lp:ubuntu-docviewer-app.
Commit message:
Allow to disable .click dependencies caching through a CMake option
Requested reviews:
Ubuntu Document Viewer Developers (ubuntu
The proposal to merge
lp:~verzegnassi-stefano/ubuntu-docviewer-app/fix-pdfview-be-visibility into
lp:ubuntu-docviewer-app has been updated.
Status: Needs review => Approved
For more details, see:
https://code.launchpad.net/~verzegnassi-stefano/ubuntu-docviewer-app/fix-pdfview-be-visibility/
Stefano Verzegnassi has proposed merging
lp:~verzegnassi-stefano/ubuntu-docviewer-app/fix-pdfview-be-visibility into
lp:ubuntu-docviewer-app.
Commit message:
[PdfView] Disable bottom edge gesture if the current document does not provide
any ToC
Requested reviews:
Ubuntu Document Viewer
Review: Needs Fixing
I left two inline comments.
As a summary, here's a diff with the changes I've proposed (line 73 is wrong -
that "imports" is not required).
The big problem with this MP is the usage of QQuickView::SizeViewToRootObject.
In my opinion it creates a lot of problems (speaking in
Review: Approve
Yes, it's more a workaround than a "rock-solid" solution, but it does the job
well and don't require to change things where it's not strictly required.
Below the Timer {}, I see that you left the Component.onCompleted handler. It
isn't necessary anymore.
Anyway, LGTM, so there'
Fixed!
--
https://code.launchpad.net/~verzegnassi-stefano/ubuntu-docviewer-app/fix-1544149/+merge/285641
Your team Ubuntu Document Viewer Developers is subscribed to branch
lp:ubuntu-docviewer-app.
--
Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers
Post to : ubuntu-touc
Review: Needs Fixing
Niklas asked me to have a look at this review, since he'll be away for a few
days.
> Let me preface this by saying I'm the original author
> of the patch:
I love this merge proposal, so thank you very much! :D
> I definitely agree it should be highlighted or something simi
I think so too.
To be fair, we shouldn't have exceptions for accessing to the user's folders
too, because of this.
Ideally the platform should provide some service that creates a database with a
list of documents, and docviewer should be authorized to access only that
database, by default.
When
The proposal to merge
lp:~verzegnassi-stefano/ubuntu-docviewer-app/desktop-support2 into
lp:ubuntu-docviewer-app has been updated.
Status: Needs review => Rejected
For more details, see:
https://code.launchpad.net/~verzegnassi-stefano/ubuntu-docviewer-app/desktop-support2/+merge/284901
--
Review: Approve
Great, LGTM. Thank you!
--
https://code.launchpad.net/~mcintire-evan/ubuntu-terminal-app/splash-screen/+merge/285673
Your team Ubuntu Terminal Developers is subscribed to branch
lp:ubuntu-terminal-app.
--
Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers
Post
Stefano Verzegnassi has proposed merging
lp:~verzegnassi-stefano/ubuntu-docviewer-app/release-2.1 into
lp:ubuntu-docviewer-app with
lp:~verzegnassi-stefano/ubuntu-docviewer-app/fix-1544149 as a prerequisite.
Commit message:
* Release Ubuntu DocViewer 2.1
* Updated changelog
Requested reviews
Review: Needs Fixing
Sorry Evan for being that hateful guy, but the branch surely needs a fix. :)
Line 9 of the diff should be:
_X-Ubuntu-Splash-Title=Terminal
Note the underscore before "X-Ubuntu-Splash-Title". That way "Terminal" can be
properly translated into user's language.
As for the r
Stefano Verzegnassi has proposed merging
lp:~verzegnassi-stefano/ubuntu-docviewer-app/fix-1544149 into
lp:ubuntu-docviewer-app.
Commit message:
Fixed ContentTransferHint being visible during an export
Requested reviews:
Ubuntu Document Viewer Developers (ubuntu-docviewer-dev)
Related bugs
@Alan: Now it should be okay. I've checked with a stopwatch and the screen
saver is properly disabled.
--
https://code.launchpad.net/~verzegnassi-stefano/ubuntu-docviewer-app/pdf-presentation-disable-screen-saver/+merge/283717
Your team Ubuntu Document Viewer Developers is subscribed to branch
l
Review: Approve
LGTM, thanks! :)
--
https://code.launchpad.net/~nikwen/ubuntu-terminal-app/color-scheme-name-mapping/+merge/285297
Your team Ubuntu Terminal Developers is subscribed to branch
lp:ubuntu-terminal-app.
--
Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers
Post
> As Stefano said[1], I do think we should avoid adding too much to the C++
> code. Whenever we end
> up redoing the clipboard stuff we could maybe remove this and the
> isClipboardEmpty() functions?
I think we can keep them as long as they are pure Qt implementations.
I had a further look at th
Review: Approve
BTW, code looks good! Great work!
--
https://code.launchpad.net/~mcintire-evan/ubuntu-terminal-app/disable-copy/+merge/285287
Your team Ubuntu Terminal Developers is requested to review the proposed merge
of lp:~mcintire-evan/ubuntu-terminal-app/disable-copy into
lp:ubuntu-termi
@Niklas: Changing the behaviour of the .pot custom target (i.e. removing the
"ALL" option) in CMake should be enough, assuming nothing else will be broken.
That would mean that you'd have to explicitely do:
mkdir build && cd dir
cmake ../
make
(bzr commit & bzr push)
So it would be some
Ack... Now I realised that the name of color schemes is hard-coded. :(
We'd have to rename the color scheme file and accordingly change the schemes
model in "ubuntu-terminal-app.qml". However it'd break the setting to the ones
who are using the "DarkPastels" theme, since the old "DarkPastel.sche
Ooh, the magical world of Launchpad trying to merge a .pot update when the
.pot has been updated in the meantime. :)
P.S. Now you know how a DocViewer developer feels, haha :'D
P.S. #2 We probably should prevent this from happening, by avoiding to
update translations every time the app is built i
@Niklas: the current "Ubuntu" theme uses exactly the same palette of
"DarkPastels".
The only differences are the background color[1] and the blue color (which in
the Ubuntu theme is shown as red).
We could rename "Dark Pastels" as "Dark Pastels / Ubuntu (old)" (or something
similar), but I don'
Review: Approve
>Here is a comparison of the font sizes with the current default:
>>https://launchpadlibrarian.net/236776246/comparison.png
>
>This shows that the values from the documentation are probably incorrect.
>However, you're right that it looks better on the phone with a ration of 1.0.
Review: Approve
LGTM, the default color scheme is properly set.
--
https://code.launchpad.net/~nikwen/ubuntu-terminal-app/fix-default-color-scheme/+merge/285273
Your team Ubuntu Terminal Developers is requested to review the proposed merge
of lp:~nikwen/ubuntu-terminal-app/fix-default-color-sche
Yes, +1!
--
https://code.launchpad.net/~nikwen/ubuntu-terminal-app/improve-list-item-design/+merge/285274
Your team Ubuntu Terminal Developers is requested to review the proposed merge
of lp:~nikwen/ubuntu-terminal-app/improve-list-item-design into
lp:ubuntu-terminal-app.
--
Mailing list: http
Review: Approve
Looks good to me. Thanks!
--
https://code.launchpad.net/~nikwen/ubuntu-terminal-app/improve-list-item-design/+merge/285274
Your team Ubuntu Terminal Developers is requested to review the proposed merge
of lp:~nikwen/ubuntu-terminal-app/improve-list-item-design into
lp:ubuntu-ter
Review: Needs Information
The MP looks good, although I'm not sure on the default and the maximum size
for the font.
I've left two inline comments.
Also, it might be nice to handle the font size in terms of 100th in the
settings page (i.e. from 4% to 500% - assuming the current range is ok).
D
1 - 100 of 466 matches
Mail list logo
