Review: Approve
Thanks for fixing that! I think the reason why nobody came back to you earlier
was that Launchpad doesn't always send notifications for everything.
The best way probably is to either send people a short email (alternatively
ping them on IRC) or to write a small message on the MP
The proposal to merge lp:~mcintire-evan/ubuntu-calendar-app/fix_readme_typo
into lp:ubuntu-calendar-app has been updated.
Status: Needs review => Approved
For more details, see:
https://code.launchpad.net/~mcintire-evan/ubuntu-calendar-app/fix_readme_typo/+merge/280670
--
Your team Ubuntu C
Looks like there have been a few changes in trunk since you branched off your
tree. Here is how to resolve this:
$ bzr branch lp:~mcintire-evan/ubuntu-terminal-app/disable-paste
$ bzr branch lp:ubuntu-terminal-app trunk
$ cd disable-paste
$ bzr merge ../trunk
$ bzr conflicts
I had a further look at the issue.
It seems that QQuickPixmapCache calls QQuickImageResponse::cancel() several
times when the LOK viewer is loaded.
We properly synchronize the threads when we queue/dequeue the task from the
engine but, if the task is currently being processed, it gets deleted du
Review: Approve continuous-integration
PASSED: Continuous integration, rev:278
https://core-apps-jenkins.ubuntu.com/job/run-ap-tests-ci/167/
Executed test runs:
None: https://core-apps-jenkins.ubuntu.com/job/generic-update-mp/449/console
Click here to trigger a rebuild:
https://core-apps-jenk
Review: Approve continuous-integration
PASSED: Continuous integration, rev:278
https://core-apps-jenkins.ubuntu.com/job/run-ap-tests-ci/166/
Executed test runs:
None: https://core-apps-jenkins.ubuntu.com/job/generic-update-mp/448/console
Click here to trigger a rebuild:
https://core-apps-jenk
Review: Approve continuous-integration
PASSED: Continuous integration, rev:278
https://core-apps-jenkins.ubuntu.com/job/run-ap-tests-ci/165/
Executed test runs:
None: https://core-apps-jenkins.ubuntu.com/job/generic-update-mp/447/console
Click here to trigger a rebuild:
https://core-apps-jenk
Stefano Verzegnassi has proposed merging
lp:~verzegnassi-stefano/ubuntu-docviewer-app/pdf-presentation-hide-mouse-cursor
into lp:ubuntu-docviewer-app.
Commit message:
[PdfPresentation] Hide mouse cursor when there's no on-going mouse event
Requested reviews:
Jenkins Bot (ubuntu-core-apps-jenk
Stefano Verzegnassi has proposed merging
lp:~verzegnassi-stefano/ubuntu-docviewer-app/pdf-presentation-full-screen into
lp:ubuntu-docviewer-app.
Commit message:
[PdfPresentation] Go automatically full-screen
Requested reviews:
Ubuntu Document Viewer Developers (ubuntu-docviewer-dev)
For more
Stefano Verzegnassi has proposed merging
lp:~verzegnassi-stefano/ubuntu-docviewer-app/pdf-presentation-disable-screen-saver
into lp:ubuntu-docviewer-app.
Commit message:
[PdfPresentation] Disable screen saver during a presentation
Requested reviews:
Ubuntu Document Viewer Developers (ubuntu-d
By doing so, the app crashes any time a document is loaded.
It does not crash always at the same point, but it may occur at two different
points:
1) In the internalRenderCallback, when it calls "doNextTask()", it crashes at
line 84 of the renderengine.cpp
if (m_activeTaskCount && !task->ca
The proposal to merge
lp:~verzegnassi-stefano/ubuntu-docviewer-app/lo-disable-spell-check into
lp:ubuntu-docviewer-app has been updated.
Status: Approved => Merged
For more details, see:
https://code.launchpad.net/~verzegnassi-stefano/ubuntu-docviewer-app/lo-disable-spell-check/+merge/28287
The proposal to merge
lp:~verzegnassi-stefano/ubuntu-docviewer-app/lo-disable-spell-check into
lp:ubuntu-docviewer-app has been updated.
Status: Needs review => Approved
For more details, see:
https://code.launchpad.net/~verzegnassi-stefano/ubuntu-docviewer-app/lo-disable-spell-check/+merge
Just remove it and manage memory yourself (in "slotTaskRenderFinished" and
"cancel").
--
https://code.launchpad.net/~verzegnassi-stefano/ubuntu-docviewer-app/lok-qml-async-imageprovider/+merge/282878
Your team Ubuntu Document Viewer Developers is requested to review the proposed
merge of
lp:~v
14 matches
Mail list logo
