(In reply to alexander :surkov from comment #25)
> (In reply to JeffreyDecker from comment #24)
> > I would like to take on this bug if that's alright.
>
> done, thank you btw.
>
> > Just reading through the
> > comments though it looks like it's a little unclear as to how we want to
> > refactor
(In reply to alexander :surkov from comment #21)
> (In reply to Ginn Chen from comment #20)
>
> > > > We need to copy the string to gchar* anyway.
> > >
> > > yep, just copy the string every time when we were asked. Doesn't sound
> > > good?
> >
> > Actually it's not possible.
> > atk_object_ge
https://hg.mozilla.org/mozilla-central/rev/e95cb5b98154
https://hg.mozilla.org/mozilla-central/rev/39acd9b60ebc
--
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/857153
Title:
Needs to get accessibility
> [Approval Request Comment]
> Regression caused by (bug #):
no bug, gnome's move away from gconf
> Testing completed (on m-c, etc.):
> Risk to taking this patch (and alternatives if risky):
> The old behavior of checking gconf will be used if the dbus call does not
> succeed (ie, if AT-SPI2 is
landed https://hg.mozilla.org/releases/mozilla-aurora/rev/c0df4333b5b7
--
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/857153
Title:
Needs to get accessibility settings from GSettings
To manage notif
(In reply to Karl Tomlinson (:karlt) from comment #44)
> That was really just guessing in comment 42, but would it make sense to skip
> the check if DBUS_SESSION_BUS_ADDRESS is unset anyway?
> If there is no session, then I assume there will be no "org.a11y.Bus".
I was thinking the same thing, bu
> I wonder whether the PreInit() in ShouldA11yBeEnabled() is really necessary
> or
> could be replaced with an assertion to check that PreInit had already been
> called. Perhaps it is needed for unit tests?
I don't think I'm familiar enough with when things happen in widget/ to
be sure that call
(In reply to Karl Tomlinson (:karlt) from comment #47)
> (In reply to Karl Tomlinson (:karlt) from comment #44)
> > If there is no session, then I assume there will be no "org.a11y.Bus".
>
> Actually there probably can still be a "org.a11y.Bus" if registered in
> /usr/share/dbus-1/services/
> http
(In reply to Karl Tomlinson (:karlt) from comment #50)
> (In reply to Trevor Saunders (:tbsaunde) from comment #49)
> > well, the firstthing that comes to mind is arranging for build machines and
> > test machines to have GNOME_ACCESSIBILITY set, do we have an idea how hard
>
(In reply to Reed Loden [:reed] (very busy) from comment #3)
> probably karlt for the gtk2 widget stuff, and maybe surkov or dbolter for
> the a11y stuff... or maybe just karlt alone.
actually, me or Ginn Chen are probably the better a11y people here, and
I think one of us should look at that sort
Comment on attachment 726580
Implement a replacement of atk_object_set_name() which mimics the behavior
without calling atk_object_get_name()
>+static void
>+AtkObjectSetName(AtkObject *aAtkObj, const gchar *name)
so, both of the times this is called we have to check if we actually
want to fire
(In reply to alexander :surkov from comment #35)
> (In reply to Trevor Saunders (:tbsaunde) from comment #34)
> > Comment on attachment 726580
> > Implement a replacement of atk_object_set_name() which mimics the behavior
> > without calling atk_object_get_name()
&
(In reply to alexander :surkov from comment #37)
> atk_object_set_name() called inside get_name is a wrong thing we try to
I think the only thing we try to fix here is the infinite recurssion.
> remove here. It made us fire name change events which is ridiculous I think.
> If I get right then ATK
(In reply to alexander :surkov from comment #39)
> (In reply to Trevor Saunders (:tbsaunde) from comment #38)
> > (In reply to alexander :surkov from comment #37)
> > > atk_object_set_name() called inside get_name is a wrong thing we try to
> >
> > I think the only t
remote: https://hg.mozilla.org/integration/mozilla-
inbound/rev/ecd327272240
--
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/948788
Title:
thunderbird crashed on launch
To manage notifications abou
Comment on attachment 729066
Implement a replacement of atk_object_set_name() which mimics the behavior
without calling atk_object_get_name()
sorry it took me so long, but I finally got to test your patch today.
It seems good so I checked it in for you ask you just saw :-)
--
You received this
remote: https://hg.mozilla.org/integration/mozilla-
inbound/rev/a5aa0a654611
--
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/948788
Title:
thunderbird crashed on launch
To manage notifications abou
Comment on attachment 738132
Implement a replacement of atk_object_set_name() which mimics the behavior
without calling atk_object_get_name()
landed again, but forgot to qref -u sorry :(
--
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubunt
Comment on attachment 728261
Implement a replacement of atk_object_set_name() which mimics the behavior
without calling atk_object_get_name()
>diff --git i/accessible/src/atk/AccessibleWrap.cpp
>w/accessible/src/atk/AccessibleWrap.cpp
>index e35da5d..208e955 100644
>--- i/accessible/src/atk/Acce
Comment on attachment 725350
Implement setNameCB() in AccessibleWrap.cpp and use it in getNameCB() instead
of atk_object_set_name()
>@@ -644,11 +644,40 @@ getNameCB(AtkObject* aAtkObj)
>
> NS_ConvertUTF8toUTF16 objName(aAtkObj->name);
> if (!uniName.Equals(objName))
>-atk_object_set_name
20 matches
Mail list logo
