[Bug 269656] Re: AN IRRELEVANT LICENSE IS PRESENTED TO YOU FREE-OF-CHARGE ON STARTUP

2008-09-20 Thread Gavin Sharp
Alexander: the nsIAboutModule you implemented in http://bazaar.launchpad.net/~mozillateam/firefox/firefox-3.0.head/revision/327 doesn't return ALLOW_SCRIPTS from its getURIFlags, so the link on the page it displays will be broken if the user has JavaScript disabled. -- AN IRRELEVANT LICENSE IS PR

[Bug 583797]

2019-01-02 Thread Gavin Sharp
I don't think we want to show a quit warning when we're restarting, e.g. for an extension install. I think that case is covered by browser.sessionstore.resume_session_once==true, which you're removing. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscri

[Bug 583797]

2019-01-02 Thread Gavin Sharp
Comment on attachment 594363 Don't disable warn-on-quit when session restore is enabled I think Paul gets to handle this one, since he really loves quitting/prompting code. (I apologize for the unreasonable delay in getting to this) -- You received this bug notification because you are a member

[Bug 480671]

2014-05-28 Thread Gavin Sharp
https://hg.mozilla.org/integration/fx-team/rev/8ecbb7a38b29 -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/480671 Title: Firefox auto-completes login fields in a case-insensitive manner To manage no

[Bug 909200]

2012-04-08 Thread Gavin Sharp
I'm not sure why you bring up the time zone - it has no impact on Firefox's behavior. Firefox by default redirects all searches to google.com, and relies on Google doing locale-detection on their end. I don't think they factor in local time in that detection - the relevant factors are usually IP ge

[Bug 909200]

2012-04-08 Thread Gavin Sharp
If this is the result of Ubuntu customizations, there isn't much we (Mozilla) can do about it. Does the same problem occur in a Firefox downloaded from mozilla.org, with the ubuntu customizations disabled (in about:addons)? -- You received this bug notification because you are a member of Ubuntu

[Bug 909200]

2012-04-08 Thread Gavin Sharp
You're welcome, hope you find a solution to the problem! -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/909200 Title: Firefox goolge search defaults to US when in Australia To manage notifications a

[Bug 306017]

2012-02-15 Thread Gavin Sharp
*** Bug 688550 has been marked as a duplicate of this bug. *** -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/306017 Title: Firefox search box should be tab specific To manage notifications about th

[Bug 1425972]

2015-03-21 Thread Gavin Sharp
ni Sylvestre for comment 93 -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1425972 Title: Firefox no longer supports -remote parameter To manage notifications about this bug go to: https://bugs.laun

[Bug 480671]

2013-12-14 Thread Gavin Sharp
(In reply to Karl Fogel from comment #53) > We changed http://wiki.opensource.org/ from Dokuwiki to XWiki, and in the > course of this change (I wasn't involved), the wiki superuser account name > changed from "admin" to "Admin". But Firefox of course still remembers the > old "admin" username, an

[Bug 480671]

2013-12-16 Thread Gavin Sharp
(In reply to Lewis Rosenthal from comment #55) > (In reply to :Gavin Sharp (email ga...@gavinsharp.com) from comment #54) > > You can type "Admin", and then click elsewhere to dismiss the autocomplete > > popup before submitting the form, right? > > > > No,

[Bug 113201]

2012-05-08 Thread Gavin Sharp
That's absolutely the best practice, don't let anyone tell you otherwise :) -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/113201 Title: firefox spends lots of time hung To manage notifications abou

[Bug 113201]

2012-05-09 Thread Gavin Sharp
Unfortunately it doesn't really make sense for us to optimize our Bugzilla practices for the casual bug watcher audience (Bugzilla really wasn't designed for that). Trying to track several different changes in a single bug just doesn't work very well. I suspect that many people on the CC list have

[Bug 1405930]

2015-01-06 Thread Gavin Sharp
*** Bug 1118160 has been marked as a duplicate of this bug. *** -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1405930 Title: must press backspace twice to delete one Persian/Arabic character To man

[Bug 1023012]

2014-06-06 Thread Gavin Sharp
Comment on attachment 8428934 leading_period.patch Thanks for the patch Awad - any chance you can file a separate bug for this? It's generally a bad idea to track multiple separate patches in the same bug, particularly one as old as this one. Please needinfo me on the new bug and I can help get th

[Bug 66566]

2014-02-04 Thread Gavin Sharp
Unfortunately fixing this at this point would be disastrous for muscle memory/user habits, so it's just not feasible. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/66566 Title: Inconsistent shortcut

[Bug 230102]

2014-02-04 Thread Gavin Sharp
This bug has outlived its usefulness - our current warning behavior is weighed towards not warning, but allowing session restore if needed. If there are specific issues those are best dealt with in narrower bugs. -- You received this bug notification because you are a member of Ubuntu Bugs, which

[Bug 230102]

2014-02-06 Thread Gavin Sharp
(In reply to Sam Steingold from comment #191) > People are unhappy about the behavior - just look at the number of dupes, > votes, and the size of the CC list. > For every person taking the trouble to report the bug, untold thousands are > cursing you under their breath. We do not draw conclusions

[Bug 306017]

2014-02-07 Thread Gavin Sharp
Comment on attachment 626243 WIP v7: tests: Don't change other tests, don't change or test for change of engine. These have bitrotted. They were left in this state in my queue mostly because answering the "should we do this?" question (as opposed to the "is this done right?" question) is difficul

[Bug 230102]

2014-02-07 Thread Gavin Sharp
(In reply to Flávio Etrusco from comment #194) > Nonetheless there's a plethora of cases that will cause data loss. (In reply to saint.snit from comment #196) > As mentioned repeatedly by people who have experienced the bug and had just > that happen to them, this is false. I encourage you both t

[Bug 66566]

2014-02-13 Thread Gavin Sharp
We can't add configuration knobs to Firefox for everything that some subset of users want changed - we'd end up with hundreds or thousands of prefs, which makes maintaining Firefox harder, and it results in horribly confusing prefs UI if the prefs are exposed there (or dramatically reduces the pref

[Bug 41179]

2014-02-13 Thread Gavin Sharp
(In reply to Eric Toombs from comment #122) You should give https://developer.mozilla.org/en-US/docs/Mozilla/js- ctypes a read - JS used in Firefox add-ons is privileged and can use JS- ctypes to interact with system libraries. -- You received this bug notification because you are a member of Ub

[Bug 217300]

2014-02-13 Thread Gavin Sharp
(In reply to Eric Toombs from comment #122) You should give https://developer.mozilla.org/en-US/docs/Mozilla/js- ctypes a read - JS used in Firefox add-ons is privileged and can use JS- ctypes to interact with system libraries. -- You received this bug notification because you are a member of Ub

[Bug 480671]

2014-02-25 Thread Gavin Sharp
Created attachment 8381156 patch Summary of changes: - add a "userTriggered" parameter to _fillForm to distinguish the onFormPassword and nsILoginManager::fillForm callers from the onUsernameInput caller - when filling any form, if there are multiple signons that match but one's username matche

[Bug 480671]

2014-02-25 Thread Gavin Sharp
https://tbpl.mozilla.org/?tree=Try&rev=b94776d97918 -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/480671 Title: Firefox auto-completes login fields in a case-insensitive manner To manage notificati

[Bug 480671]

2014-02-25 Thread Gavin Sharp
(In reply to Florian Fischer from comment #58) > Now how can I recall the password for user? If I press 'u' and select > 'user' from the dropdown, it fills in 'User'. If I type 'user' and I tab > out of the field, it gets converted to 'User'. In both cases the password > is 'p'. If I type 'user

[Bug 684982]

2014-11-17 Thread Gavin Sharp
*** Bug 890125 has been marked as a duplicate of this bug. *** -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/684982 Title: Firefox windows don't restore on correct workspaces To manage notification

[Bug 643899]

2014-09-21 Thread Gavin Sharp
(In reply to Richard Newman [:rnewman] from comment #4) > I think the code as written will grab intl.properties instead of actually > reading > the real value. It will indeed, but that's not necessarily a problem if it sets the pref the same way (setComplexValue(..., nsISupportsString)), as long

[Bug 480671]

2014-07-18 Thread Gavin Sharp
Embarassing! Thanks for catching that. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/480671 Title: Firefox auto-completes login fields in a case-insensitive manner To manage notifications about thi

[Bug 192092]

2012-12-16 Thread Gavin Sharp
It looks like bug 822068 is also touching this code. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/192092 Title: ctrl+shift+pg.up/dn does not move tabs To manage notifications about this bug go to:

[Bug 481541]

2013-02-14 Thread Gavin Sharp
This is not a suitable default behavior, and I don't think it's commonly desired enough to add as an option (on some platforms it may not even be doable). -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/

[Bug 526453]

2012-07-25 Thread Gavin Sharp
*** Bug 776153 has been marked as a duplicate of this bug. *** -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/526453 Title: Firefox does not allow users to change the default search engine, unless

[Bug 526453]

2012-08-15 Thread Gavin Sharp
*** Bug 782559 has been marked as a duplicate of this bug. *** -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/526453 Title: Firefox does not allow users to change the default search engine, unless

[Bug 428306]

2012-08-24 Thread Gavin Sharp
(In reply to Chris Coulson from comment #14) > Whilst normalize() works for us, it probably wouldn't work in all cases (ie, > if the application directory can move around and nobody symlinked the > distribution folder to a stable path). As a simple interim solution for what is kind of an edge case

[Bug 310217]

2012-06-08 Thread Gavin Sharp
The code intentionally uses the default engine, it's not a matter of accidentally reading the wrong pref (the prefs are internal to the search service, the users can choose to use either .defaultEngine or .currentEngine, as shown in the patch). -- You received this bug notification because you ar

[Bug 355112]

2013-03-28 Thread Gavin Sharp
*** Bug 855248 has been marked as a duplicate of this bug. *** -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/355112 Title: Ask.com keeps being re-added to Firefox search bar after updates To manage

[Bug 526453]

2013-03-14 Thread Gavin Sharp
We're going to add some preferences UI for selecting a default engine in bug 738818. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/526453 Title: Firefox does not allow users to change the default se

[Bug 192092]

2012-12-06 Thread Gavin Sharp
*** Bug 702960 has been marked as a duplicate of this bug. *** -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/192092 Title: ctrl+shift+pg.up/dn does not move tabs To manage notifications about this

[Bug 192092]

2013-01-04 Thread Gavin Sharp
Comment on attachment 689087 patch version 2 Code-wise, this looks good. I think the only suggestions I would make is that we should probably limit this behavior to Linux somehow (probably by using an #ifdef XP_GNOME like the one in browser-sets.inc). I don't know the answers to ithinc's concerns

[Bug 192092]

2013-01-04 Thread Gavin Sharp
(In reply to ithinc from comment #9) > Noticed that these key combinations have been used in Caret Browsing mode. Do you have a pointer to the code? -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/19209

[Bug 192092]

2013-01-06 Thread Gavin Sharp
OK, let's do this then! Thanks again for the patch, Marius. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/192092 Title: ctrl+shift+pg.up/dn does not move tabs To manage notifications about this bu

[Bug 480671]

2012-02-23 Thread Gavin Sharp
*** Bug 727798 has been marked as a duplicate of this bug. *** -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/480671 Title: Firefox auto-completes login fields in a case-insensitive manner To manage

[Bug 610915]

2011-06-29 Thread Gavin Sharp
*** Bug 667970 has been marked as a duplicate of this bug. *** -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/610915 Title: auto complete user name do not allow to choose some users To manage notifi

[Bug 612377]

2011-04-04 Thread Gavin Sharp
More specifically, with yasm 0.8.0.2194, which is the latest available by default with Ubuntu 10.04. yasm 1.1.0.2352 works fine. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/612377 Title: [needs-pa

[Bug 310217]

2011-05-06 Thread Gavin Sharp
*** Bug 655106 has been marked as a duplicate of this bug. *** -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/310217 Title: Wrong search engine in right-click menu only in "wide screen" mode -- ubu

[Bug 239926]

2011-05-03 Thread Gavin Sharp
Comment on attachment 524711 Proposed, exceedingly simple patch Rather than doing this, I'd just remove the "button" attribute on the existing handler in favor of code that checks (event.button == 0 || event.button == 1). But I'm not sure it makes sense to do this at all, it doesn't seem like a c

[Bug 504644]

2011-04-12 Thread Gavin Sharp
*** This bug has been marked as a duplicate of bug 252602 *** -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/504644 Title: Firefox icon in "About Mozilla Firefox" doesn't handle horizontal resizing

[Bug 239826]

2011-04-26 Thread Gavin Sharp
(In reply to comment #99) > this bug is present in 4.0 as well as today's Nightly, so I suppose it > regressed somewhere along the way. I filed bug 652542. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bug