[Bug 537050] Re: miro.real crashed with KeyError in wrapper() (Miro keeps running)

2010-04-19 Thread Ben Dean-Kawamura
I don't think it was upgrading that fixed the issue directly. What happened is that Miro started using xulrunner-1.9.1 rather than xulrunner 1.9.2. I'm not sure why that happened exactly, but I just checked in some code that forces it to happen and I think that does the trick. So here's what I t

[Bug 537050] Re: miro.real crashed with KeyError in wrapper() (Miro keeps running)

2010-04-14 Thread Ben Dean-Kawamura
I'm pretty sure that this is caused from a XULRunner bug. Here's a test script that shows the problem. If you run it you should see a GtkMozEmbed widget. Then click the button. This should remove the widget. So far everything's fine. However, when you click the button again, the script will t

[Bug 537050] Re: miro.real crashed with KeyError in wrapper() (Miro keeps running)

2010-04-15 Thread Ben Dean-Kawamura
Here's a patch that works around the issue for me. It's definitely not a pretty solution, we just short-circuit the code that mozilla has to handle un-realize/re-realize. At the very least this is a memory leak, however it only leaks when the user deletes sites, which isn't going to happen very o

[Bug 537050] Re: miro.real crashed with KeyError in wrapper() (Miro keeps running)

2010-04-15 Thread Ben Dean-Kawamura
Sorry, my first attempt was a patch against master. Here's one against the 3.0 branch, which is used in lucid. ** Patch added: "mozembed-realize.patch" http://launchpadlibrarian.net/44350553/mozembed-realize.patch -- miro.real crashed with KeyError in wrapper() (Miro keeps running) https://b

[Bug 537050] Re: miro.real crashed with KeyError in wrapper() (Miro keeps running)

2010-04-15 Thread Ben Dean-Kawamura
Upgrading to xulrunner-1.9.2.3 fixed the issue for me. Does it fix it for others? -- miro.real crashed with KeyError in wrapper() (Miro keeps running) https://bugs.launchpad.net/bugs/537050 You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu.