Re: [Bug 688541] Re: race condition on shutdown (leads to corrupted fs)

2010-12-23 Thread Clint Byrum
On Thu, 2010-12-23 at 22:07 +, ingo wrote: > I took you literally and canged all [!2345], not the others: > > The remaining now are: > > fgrep "stop on runlevel" /etc/init/*.conf > /etc/init/rc.conf:stop on runlevel [!$RUNLEVEL] > /etc/init/rcS.conf:stop on runlevel [!S] > /etc/init/rc-sysini

Re: [Bug 688541] Re: race condition on shutdown (leads to corrupted fs)

2010-12-23 Thread Clint Byrum
On Thu, 2010-12-23 at 12:40 +, ingo wrote: > @Clint: > > I did test your proposal in Maverick. > > Before editing the stop scripts: > > fgrep "stop on runlevel" /etc/init/*.conf > /etc/init/acpid.conf:stop on runlevel [!2345] > /etc/init/anacron.conf:stop on runlevel [!2345] > /etc/init/appo

Re: [Bug 688541] Re: race condition on shutdown (leads to corrupted fs)

2010-12-21 Thread Michael Biebl
2010/12/21 ingo <688...@bugs.launchpad.net>: > On Tue, 2010-12-21 at 12:41 +, Scott James Remnant wrote: >> General note: ubuntu-devel is *NOT* the correct list to discuss Upstart >> changes unless they're unique to Ubuntu. > > Wouldn't it be fair to inform Debian about those problems before th

Re: [Bug 688541] Re: race condition on shutdown (leads to corrupted fs)

2010-12-21 Thread Clint Byrum
On Tue, 2010-12-21 at 12:41 +, Scott James Remnant wrote: > On 20/12/10 18:22, Clint Byrum wrote: > > In a message to ubuntu-devel I suggested that we have an abstract job, > > 'network-services', which most normal (non boot-critical) services > > should follow. > > > > https://lists.ubuntu.com

Re: [Bug 688541] Re: race condition on shutdown (leads to corrupted fs)

2010-12-20 Thread Clint Byrum
On Mon, 2010-12-20 at 12:50 +, James Hunt wrote: > After discussion with Scott, the best short-term solution would seem to > be: > > 1) Modify /etc/init.d/umountfs to call the following in do_stop before > calling umount/swapoff: > > "initctl emit unmount-filesystem" > > 2) Modify /etc/

Re: [Bug 688541] Re: race condition on shutdown (leads to corrupted fs)

2010-12-20 Thread Michael Biebl
2010/12/20 James Hunt <688...@bugs.launchpad.net>: > > 3) Modify all upstart configs for services which are "slow" to stop such that > they "stop on unmount-filesystem", >    rather than "stop on runlevel [016]". - What about single user mode? I guess when switching to runlevel 1 we want to stop

Re: [Bug 688541] Re: race condition on shutdown (leads to corrupted fs)

2010-12-16 Thread Clint Byrum
On Thu, 2010-12-16 at 15:45 +, Michael Biebl wrote: > 2010/12/16 Clint Byrum : > > > > > > I'm attaching a debdiff that solves the race as far as I can tell, > > though I think it needs a good long look, since it could mean shutdowns > > hang for a long time waiting (I'm especially curious if

Re: [Bug 688541] Re: race condition on shutdown (leads to corrupted fs)

2010-12-16 Thread Michael Biebl
2010/12/16 Clint Byrum : > > /etc/init.d/sendsigs has this code: > > >        # Upstart jobs have their own "stop on" clauses that sends >        # SIGTERM/SIGKILL just like this, so if they're still running, >        # they're supposed to be >        for pid in $(initctl list | sed -n -e "/process

Re: [Bug 688541] Re: race condition on shutdown (leads to corrupted fs)

2010-12-13 Thread Michael Biebl
2010/12/14 Clint Byrum : > > I do think the appropriate fix is to have umountfs emit an 'unmounting- > filesystems' event and anything that does a 'start on local-filesystems' > or 'start on filesystem' should also 'stop on unmounting-filesystems', What do you do about services which have "start o

Re: [Bug 688541] Re: race condition on shutdown (leads to corrupted fs)

2010-12-10 Thread Michael Biebl
2010/12/10 Ante Karamatić : > Suggestion: make umountfs wait for all upstart jobs to finish. Doesn't that conflict though with what is written in /etc/init.d/sendsigs: # Upstart jobs have their own "stop on" clauses that sends # SIGTERM/SIGKILL just like this, so if they're still