Re: [Bug 1130232] Re: Implement GenericIpAddressField in MAAS rather than django.

2013-02-21 Thread Raphaël Badin
> Either way, this shouldn't be solved in packaging.. it's core support > needed in MAAS for backwards compatibility. More importantly, fixing this upsteam is better because it means that the monkey patching code and the code stolen from django 14 gets exercised when we run the test suite on a p

Re: [Bug 1130232] Re: Implement GenericIpAddressField in MAAS rather than django.

2013-02-20 Thread Julian Edwards
On Wednesday 20 Feb 2013 19:54:21 Raphaël Badin wrote: > On 02/20/2013 08:32 PM, Andres Rodriguez wrote: > > Oh btw... we need to make sure that this doesn't provide any regression > > or upgrade failures from those who have been using MAAS from ppa:maas- > > maintainers/stable. > > Good point, th

Re: [Bug 1130232] Re: Implement GenericIpAddressField in MAAS rather than django.

2013-02-20 Thread Raphaël Badin
On 02/20/2013 04:11 PM, Raphaël Badin wrote: > On 02/20/2013 03:54 PM, Dave Walker wrote: >> Does it make sense to monkey patch if django < required version? > > It's also a possibility, but given the way Django plays with imports, > this could be a dangerous game. That being said, the monkey patc

Re: [Bug 1130232] Re: Implement GenericIpAddressField in MAAS rather than django.

2013-02-20 Thread Raphaël Badin
On 02/20/2013 08:32 PM, Andres Rodriguez wrote: > Oh btw... we need to make sure that this doesn't provide any regression > or upgrade failures from those who have been using MAAS from ppa:maas- > maintainers/stable. Good point, that's another argument in favor of the monkey patch solution. -- Y

Re: [Bug 1130232] Re: Implement GenericIpAddressField in MAAS rather than django.

2013-02-20 Thread Raphaël Badin
On 02/20/2013 03:54 PM, Dave Walker wrote: > Does it make sense to monkey patch if django < required version? It's also a possibility, but given the way Django plays with imports, this could be a dangerous game. > Either way, this shouldn't be solved in packaging.. it's core support > needed in

Re: [Bug 1130232] Re: Implement GenericIpAddressField in MAAS rather than django.

2013-02-20 Thread Dave Walker
Does it make sense to monkey patch if django < required version? Either way, this shouldn't be solved in packaging.. it's core support needed in MAAS for backwards compatibility. Thanks. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu

Re: [Bug 1130232] Re: Implement GenericIpAddressField in MAAS rather than django.

2013-02-19 Thread Julian Edwards
Hey Andres, Upstream doesn't have packaging really. The packaging branch that's there belongs to Ubuntu, it just happens to be owned by Maas maintainers. Cheers Andres Rodriguez wrote: >Hi Julian, > >This bug does not belong to the packaging nor MAAS *in* Ubuntu, because >GenericIpAddressField