[Bug 986973] Re: Facter bug causes puppet to hang

2013-09-19 Thread Launchpad Bug Tracker
This bug was fixed in the package facter - 1.6.5-1ubuntu1.2 --- facter (1.6.5-1ubuntu1.2) precise; urgency=low * d/p/thread-critical-freeze: fix "puppet apply" hang by avoiding unnecessary thread critical sections (LP: #986973). -- Robie BasakTue, 02 Jul 2013 03:21:36 +

[Bug 986973] Re: Facter bug causes puppet to hang

2013-09-17 Thread Tuomas Starck
tl;dr: I second the verification Dear everyone, I have used puppet to maintain a collection of some dozens of Precise servers. This bug, as described, has manifested regularly. I've enabled the precise-proposed repository on a few test servers and updated facter to 1.6.5-1ubuntu1.2. Based on som

[Bug 986973] Re: Facter bug causes puppet to hang

2013-07-28 Thread Robie Basak
In the ten days before applying the -proposed update (1.6.5-1ubuntu1.2), one of my affected servers had nine failures (I haven't been testing any others). In the ten days since applying the -proposed update, the same server has had no failures at all. I haven't made any other changes in this time.

[Bug 986973] Re: Facter bug causes puppet to hang

2013-07-18 Thread Dave Walker
As discussed with Robie, this upload is being folded with the current one for dual verification. ** Changed in: facter (Ubuntu Precise) Status: In Progress => Fix Committed ** Tags added: verification-needed -- You received this bug notification because you are a member of Ubuntu Bugs, w

[Bug 986973] Re: Facter bug causes puppet to hang

2013-07-11 Thread Dave Walker
This is blocked on in-flight SRU bug 1170325. Thanks -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/986973 Title: Facter bug causes puppet to hang To manage notifications about this bug go to: http

[Bug 986973] Re: Facter bug causes puppet to hang

2013-07-01 Thread Robie Basak
** Description changed: [Impact] "puppet apply" hangs about 20% of the time on affected servers. This affects users using puppet without a puppetmaster. The normal use case is to make "puppet apply" run regularly. This causes hung puppet processes to build up, eventually exhausting sy

[Bug 986973] Re: Facter bug causes puppet to hang

2013-07-01 Thread Robie Basak
(this appears fixed in Saucy, so just the Precise SRU needed) ** Description changed: + [Impact] + + "puppet apply" hangs about 20% of the time on affected servers. This + affects users using puppet without a puppetmaster. The normal use case + is to make "puppet apply" run regularly. This cause

[Bug 986973] Re: Facter bug causes puppet to hang

2013-06-28 Thread Robie Basak
I found a machine exhibiting this problem. On Precise (facter 1.6.5-1ubuntu1), I ran the following experiments: No patch: "puppet apply" failed 20 out of 100 runs. Patched both memory.rb and processor.rb: "puppet apply" failed 0 out of 100 runs. Patched only memory.rb: "puppet apply" failed 23 ou

[Bug 986973] Re: Facter bug causes puppet to hang

2013-06-18 Thread Jared Biel
@Shane Yes - it appears you are correct and I was in error in my previous comment. The source file lib/facter/processor.rb does not make use of Thread::Exclusive (except for Windows), but lib/facter/util/processor.rb does, so it's necessary to patch that file also. -- You received this bug notif

[Bug 986973] Re: Facter bug causes puppet to hang

2013-06-18 Thread Shane Meyers
Installing the patched version of memory.rb from https://github.com/puppetlabs/facter/commit/9ff4453b2f0843df887ae1ec2098a4336291df0c helped reduce the number of puppet hangs that we experience, but we were still getting hung processes. Attaching strace to a "hung" puppet process showed a constant

[Bug 986973] Re: Facter bug causes puppet to hang

2013-06-13 Thread Robie Basak
We'll also need this fixed in Saucy before we can commence an SRU. What is the fix needed in Saucy? Just memory.rb? The same patch? Or processor.rb as well? -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bug

[Bug 986973] Re: Facter bug causes puppet to hang

2013-06-13 Thread Robie Basak
@Shane Could you please confirm the patch that you're using on memory.rb, and confirm that this fixes the problem for you? I've also been seeing 'puppet apply' hanging via cron, but never figured out if this was the issue or if this patch fixed it. I've been working around it with a timeout. If

[Bug 986973] Re: Facter bug causes puppet to hang

2013-06-12 Thread Shane Meyers
It would be fantastic if we could get memory.rb back ported to Precise, as this is really irritating to need to maintain a separate copy of memory.rb. Without the patched version, we experience many hangs per day with 'puppet apply' running via cron. Surprising to see a hang bug remain for so lon

[Bug 986973] Re: Facter bug causes puppet to hang

2013-06-11 Thread Jared Biel
I just did some digging and found that processor.rb isn't affected in versions 1.6.5 (precise) or 1.6.9. So, commit 9ff4453b2f0843df887ae1ec2098a4336291df0c is the only necessary one to cherry-pick here. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subsc

[Bug 986973] Re: Facter bug causes puppet to hang

2013-06-11 Thread Jared Biel
@Robie Basak The copy of memory.rb that you linked in your update does contain the fix (removal of "require 'thread'" etc.) I just checked out the tag 1.7.0 and found the commit (https://github.com/puppetlabs/facter/commit/9ff4453b2f0843df887ae1ec2098a4336291df0c). Note: that commit is only for me