[Bug 787736] Re: memory leak in rebuild

2012-04-14 Thread Charles Kerr
JKL's patch is a good improvement, but it's been a few months since it was submitted there are some newer complications in the code, specifically having a weak reference to each widget s.t. we can handle the case of a widget being destroyed while it's still got a rebuild pending. lp:~charlesk/appm

[Bug 787736] Re: memory leak in rebuild

2011-06-17 Thread JKL
I'm not sure what you are saying, but looking back at it now, I think the patch I wrote was overcomplicated. The design can be simplified considerably, and in doing so two additional issues can be addressed. The first issue has to do with scheduling. The existing design cancels the prior scheduled

[Bug 787736] Re: memory leak in rebuild

2011-06-16 Thread Ted Gould
Thanks for the patch. As you see attached to this bug, I've put it into a Bazaar branch to make it slightly easier to track. It seems that do_rebuild() needs to get passed the entry now instead of data because it needs to remove the entry from the rebuild_ids hash table not data->widget. Does th

[Bug 787736] Re: memory leak in rebuild

2011-06-16 Thread Launchpad Bug Tracker
** Branch linked: lp:~ted/appmenu-gtk/lp787736 -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/787736 Title: memory leak in rebuild To manage notifications about this bug go to: https://bugs.launchpa

[Bug 787736] Re: memory leak in rebuild

2011-05-27 Thread Mathieu Trudel-Lapierre
** Changed in: appmenu-gtk (Ubuntu) Status: New => Triaged ** Changed in: appmenu-gtk (Ubuntu) Importance: Undecided => Medium ** Also affects: appmenu-gtk Importance: Undecided Status: New -- You received this bug notification because you are a member of Ubuntu Bugs, which

[Bug 787736] Re: memory leak in rebuild

2011-05-25 Thread Brian Murray
** Tags added: patch -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/787736 Title: memory leak in rebuild -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/li

[Bug 787736] Re: memory leak in rebuild

2011-05-24 Thread JKL
One more thing -- app_menu_bridge_insert does not release the "attach- widget" reference it gets, causing another leak. No patch. It's a one-liner. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/787736

[Bug 787736] Re: memory leak in rebuild

2011-05-24 Thread JKL
** Patch added: "patched against natty version appmenu-gtk_0.2.1-0ubuntu3" https://bugs.launchpad.net/bugs/787736/+attachment/2141293/+files/fix-memory-leaks -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.ne