[Bug 735656] Re: Users on highlight ignore are completely ignored

2013-10-14 Thread Rubin
Just a "me too" comment. Nicks listed in irc_no_hilight do not produce output when PRIVMSG a channel. (But show in the raw log). This bug is very old. Could someone please git rm 71_fix_nick_not_to_highlight.patch so this can be resolved? No point in ubuntu making xchat worse than stock. Or state

[Bug 735656] Re: Users on highlight ignore are completely ignored

2013-02-05 Thread knivey
this bug was reported in 2011 and it still isn't fixed in 2013? It would be nice if I didn't have to compile xchat.. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/735656 Title: Users on highlight ig

Re: [Bug 735656] Re: Users on highlight ignore are completely ignored

2012-04-12 Thread Mika Suomalainen
Hi, 12.04.2012 20:33, Sandeep Kamath kirjoitti: > Its still happening in precise. > > I rebuilt the package after removing patch 71 with some help from google. not > sure if theres an easier way to do it, but this is how I did it: > *might be best if you made a separate dir and cd to it* > sudo

[Bug 735656] Re: Users on highlight ignore are completely ignored

2012-04-12 Thread Sandeep Kamath
Its still happening in precise. I rebuilt the package after removing patch 71 with some help from google. not sure if theres an easier way to do it, but this is how I did it: *might be best if you made a separate dir and cd to it* sudo apt-get install build-essential sudo apt-get build-dep xchat

[Bug 735656] Re: Users on highlight ignore are completely ignored

2012-01-23 Thread Rainer Müller
This broken behavior is caused by the patch added as a result from LP #669046. As this makes the situation worse than before, please revert this patch. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/735

[Bug 735656] Re: Users on highlight ignore are completely ignored

2011-11-07 Thread Daniel Gimpelevich
Problem still exists in oneiric. Please fix! -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/735656 Title: Users on highlight ignore are completely ignored To manage notifications about this bug go t

[Bug 735656] Re: Users on highlight ignore are completely ignored

2011-11-07 Thread Launchpad Bug Tracker
Status changed to 'Confirmed' because the bug affects multiple users. ** Changed in: xchat (Ubuntu) Status: New => Confirmed -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/735656 Title: Users

[Bug 735656] Re: Users on highlight ignore are completely ignored

2011-03-24 Thread kvdveer
Simply undoing patch 71 fixes the bug; it does more harm than good. It doesn't do any good anyway. Properly reimplementing patch 71 is not a triviality; it would require new text events, and the infrastructure to propagate those. -- You received this bug notification because you are a member of

[Bug 735656] Re: Users on highlight ignore are completely ignored

2011-03-24 Thread kvdveer
My proposed change above is wrong. Line 442-443 are entirely unneeded. Checking whether we should highlight for from nick is already performed in is_hilight, there is no need to do that in inbound_chanmsg. The same is true for the tail of inbound_privmsg. I'll fix it, test it, and submit a subs

[Bug 735656] Re: Users on highlight ignore are completely ignored

2011-03-24 Thread kvdveer
I think this is caused by 71_fix_nick_not_to_highlight.patch On line 442, inbound_chanmsg: if (alert_match_word (from, prefs.irc_no_hilight)) return; // <<<--- returning, without delivering the message if (is_hilight (from, text, sess, serv)) hiligh

[Bug 735656] Re: Users on highlight ignore are completely ignored

2011-03-15 Thread Sandeep Kamath
** Summary changed: - Users on highlight ignore and completely ignored + Users on highlight ignore are completely ignored -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/735656 Title: Users on highli