Added memory barriers upstream as:
http://cgit.freedesktop.org/libreoffice/ure/commit/?id=75f9926ecd485c349b5c66b8881aa5137aacde26
--
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/726529
Title:
use a
This bug was fixed in the package libreoffice - 1:3.3.1-1ubuntu5
---
libreoffice (1:3.3.1-1ubuntu5) natty; urgency=low
* completely disable the arm patch for natty (LP: #726529)
* make libreoffice-gtk recommend either tango or human (LP: #726921)
* added ppc fixes (LP: #727118)
This is how the two routines need to be modified:
The code block needs to be wrapped by dmb (memory barrier instruction)
register int nCount __asm__ ("r1");
int nResult;
__asm__ __volatile__ (
"dmb\n" <- here
"1: ldrex %0, [%3]\n"
" add %0, %0, #1\n"
" strex %1, %0, [%3]\n"
@Jani: As the original code by Erics Bachard is not guaranteed to be SMP-safe,
could you please post a patch with the linaro generated code, so we could
completely replace the asm code in:
http://cgit.freedesktop.org/libreoffice/ure/commit/?id=83f2c071758ae7d74669d992e272e50057b895ed
at upstrea
removed the arm patches on natty:
http://git.debian.org/?p=pkg-openoffice/libreoffice.git;a=commit;h=47a49ddab9633c45c33a949fe109a8087ef5b141
reenabled the patch for maverick and natty:
http://git.debian.org/?p=pkg-openoffice/libreoffice.git;a=commit;h=b8943507ab7a3c96c21d3c9ae0292b9cf7fa7152
http
>From what doko says indeed on non-Ubuntu (and thus non Linaro) gcc 4.5
does not generate the more optimal code.
In general I was confused by the fact that this is not natty specific. I
was thinking lucid/maverick etc have their own packaging branches and
the natty package does not carry legacy st
Jani: If I understood doko's discussion correctly it we would still need it as
4.5 Linaro not 4.5 FSF.
@doko: Please confirm.
Other than that, the patch would not hurt either way as-is (because it
generates the same code), right?
--
You received this bug notification because you are a member of
** Changed in: libreoffice (Ubuntu)
Assignee: (unassigned) => Björn Michaelsen (bjoern-michaelsen)
--
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/726529
Title:
use arm assembly bits only for gcc
On 28.02.2011 17:49, Jani Monoses wrote:
> gcc 4.5 generates the same code as in the assembly - or is it just gcc-4.5
> linaro on natty?
yes.
> Even better it adds a dmb instruction which the asm block is missing, causing
> it to not be SMP safe.
>
> Code generated by default gcc 4.5 on natty.
gcc 4.5 generates the same code as in the assembly - or is it just gcc-4.5
linaro on natty?
Even better it adds a dmb instruction which the asm block is missing, causing
it to not be SMP safe.
Code generated by default gcc 4.5 on natty.
a: f04f 0201 mov.w r2, #1
e: f3bf 8f5f
Commited to master as:
http://cgit.freedesktop.org/libreoffice/ure/commit/?id=83f2c071758ae7d74669d992e272e50057b895ed
--
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/726529
Title:
use arm assembly bi
** Summary changed:
- drop arm assembly bits from patch
+ use arm assembly bits only for gcc < 4.6 on ARM > 6
--
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/726529
Title:
use arm assembly bits only
12 matches
Mail list logo
